[
https://issues.apache.org/jira/browse/TINKERPOP3-695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14565985#comment-14565985
]
Ran Magen commented on TINKERPOP3-695:
--------------------------------------
Hey Stephen,
1. {{supportsNumericIds}} has always been {{false}} in elastic-gremlin. I
didn't realize you meant for me to change that.
2. The fixes in IoTest solve those failing tests :) (except for a few that
still fail, but now because of a bug on my side)
3. I overrided willAllowId(id) and always return true (since I just call
toString for whatever id I receive), but the coverage didn't change (740 total,
318 ignored).
4. The Feature tests still fail...
Thanks again for taking the time to solve this!
> test not calling convertId()
> ----------------------------
>
> Key: TINKERPOP3-695
> URL: https://issues.apache.org/jira/browse/TINKERPOP3-695
> Project: TinkerPop 3
> Issue Type: Improvement
> Components: test-suite
> Reporter: Ran Magen
> Assignee: stephen mallette
> Fix For: 3.0.0.GA
>
>
> any test that uses Attachable to load its graph (e.g. using the Gryo loader)
> will not pass the id through the graph providers convertId(id). there are
> around 60 different tests affected.
> The offending line:
> https://github.com/apache/incubator-tinkerpop/blob/4bbbb6365f36c20ad63ca4665657fd1169a7d246/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/util/Attachable.java#L276
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
