[
https://issues.apache.org/jira/browse/TINKERPOP3-695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14567255#comment-14567255
]
stephen mallette commented on TINKERPOP3-695:
---------------------------------------------
Slight adjustment to the previous commit:
https://github.com/apache/incubator-tinkerpop/commit/c520013dea8900f65047d7ea7c3575625c3533a2
I think it's better to use "assume" so that the tests are ignored rather than
simply passed. If a graph doesn't {{support*Ids}} but returns true for that
specific id on {{willAllowId}} then that test really shouldn't be executed in
the first place as its assertions do not apply.
I think that should solve your problem here. Please let me know if this issue
is resolved now.
> test not calling convertId()
> ----------------------------
>
> Key: TINKERPOP3-695
> URL: https://issues.apache.org/jira/browse/TINKERPOP3-695
> Project: TinkerPop 3
> Issue Type: Improvement
> Components: test-suite
> Reporter: Ran Magen
> Assignee: stephen mallette
> Fix For: 3.0.0.GA
>
>
> any test that uses Attachable to load its graph (e.g. using the Gryo loader)
> will not pass the id through the graph providers convertId(id). there are
> around 60 different tests affected.
> The offending line:
> https://github.com/apache/incubator-tinkerpop/blob/4bbbb6365f36c20ad63ca4665657fd1169a7d246/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/util/Attachable.java#L276
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
