Github user spmallette commented on a diff in the pull request:

    https://github.com/apache/incubator-tinkerpop/pull/109#discussion_r42361719
  
    --- Diff: 
gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/GremlinServer.java
 ---
    @@ -71,21 +74,33 @@
         private final EventLoopGroup workerGroup;
         private final ExecutorService gremlinExecutorService;
         private final ServerGremlinExecutor<EventLoopGroup> 
serverGremlinExecutor;
    +    private final boolean isLinuxOS;
     
         /**
          * Construct a Gremlin Server instance from {@link Settings}.
          */
         public GremlinServer(final Settings settings) {
             this.settings = settings;
    +        this.isLinuxOS = settings.useEpollEventLoop && 
SystemUtils.IS_OS_LINUX;
    --- End diff --
    
    minor nit....can you please rename `isLinuxOS` to something more fitting, 
like `epollEnabled`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to