Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/109#issuecomment-149652503
VOTE: +1
This PR feels ready for general review from committers. Here's a summary
for those who haven't been following along:
* The PR adds a configuration to Gremlin Server to use a linux-only netty
feature that has shown to improve performance.
* @anagav was good enough to work tests such that we can run Gremlin Server
integration tests with and without this feature by way of a secondary maven
profile. In this way we can run tests on any platform.
From my testing perspective, I successfully did:
```text
mvn clean install
cd gremlin-server
mvn verify -DskipIntegrationTests=false
mvn verify -DskipIntegrationTests=false -Plinux
```
Even if you're not testing on linux it would be good to try the `-Plinux`
option as it will validate the fallback to java NIO and still work.
I'll handle the merge of this PR (when the VOTE is complete) and update
changelog in the process.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
