Github user spmallette commented on a diff in the pull request:
https://github.com/apache/incubator-tinkerpop/pull/109#discussion_r42361097
--- Diff: gremlin-server/pom.xml ---
@@ -148,6 +149,29 @@ limitations under the License.
</build>
<profiles>
<profile>
+ <id>linux</id>
+ <activation>
+ <os>
+ <family>Linux</family>
--- End diff --
Doesn't this mean that if I'm on linux, i'll always be testing epoll as the
profile "activates" when the os is linux? I think we'd want the flexibility to
be able to test java nio on linux, which we don't get on this approach. In
other words, instead of activating by os, it should activate when requested
with:
```xml
<activation>
<activeByDefault>false</activeByDefault>
<property>
<name>epoll</name>
</property>
</activation>
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
