Fabien Carrion wrote:
Hi,
Here is my point of view.
I like the idea of "<create a new instance through various kinds of
magic>" to be replaced by "nice code that can do the object creation
and injection in one step".
As I am still new on the code of Tomcat, having all the code
concentrated for the object creation and injection is a good idea. I
remember to have problem to find out where the filter, servlet...
objects were created when I did my first patch on the annotations. But
I have no solution to implement it on tomcat.
I agree, I think what David J was trying to do, replace this with a
single piece of code, however wasn't really successful in conveying that
message into nice code.
There were two goals:
1. Refactor the loadClass and newInstance into a single spot
2. Apply whatever logic you needed when a new instance was created,
perhaps even annotion processing
The patch doesn't seems to modify nothing on the catalina side
(ContextConfig.java, WebRuleSet.java, WebAnnotationSet.java). Just the
jasper side is taken in account.
Yes, Bill pointed out how an invalid dependency was created, I have
communicated this back to David.
I don't think an adapter between the LifecycleProvider interface and the
AnnotationProcessor interface is a good idea. This is one layer more
between the code which does the work and the code which requires the
work. The adapter has to be maintained. It is more work for us.
True, I sent the feedback, lets see what happens.
Filip
Cheer's
Fabien
On 3/24/07, Filip Hanik - Dev Lists <[EMAIL PROTECTED]> wrote:
yo,
I've been in touch with the folks at Geronimo.
They use dependency injection, and have a suggestion on how they would
like the annotation processor to be able to be injected into tomcat
Here is the email
http://marc.info/?l=geronimo-dev&m=117467149802844&w=2
Here is the proposed patch:
https://issues.apache.org/jira/secure/attachment/12354097/GERONIMO-3010-1.patch
I'd take out the word LifecycleProvider, and replace it with something
else as it conflicts with our own idea of Lifecycle.
I'd like to get your feedback, this is a chance step for our two
communities to work together.
Filip
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
