On 29 February 2012 18:07, Jeremy Boynes <jboy...@apache.org> wrote: > Reverted r1294943. > > Do you know how this was addressed in Commons?
Yes, see commons-parent pom http://repo1.maven.org/maven2/org/apache/commons/commons-parent/23/commons-parent-23.pom search for NOTICE > Any patches? :) > > On Feb 29, 2012, at 9:14 AM, sebb wrote: > >> On 29 February 2012 05:11, Konstantin Kolinko <knst.koli...@gmail.com> wrote: >>> 2012/2/29 Jeremy Boynes <jboy...@apache.org>: >>>> Removed from svn. A dry run of the next release shows they are >>>> automatically added to the source bundle. >>>> >>> >>> 1. Where it takes those files from? Is their content correct. >>> >>> Besides extra blank lines before and after the text in NOTICE file, >> >> I'd forgotten about that - that's one reason why we don't use the >> auto-generated N&L files in Commons. >> [In a previous Maven release, IIRC the NOTICE file had even more >> extraneous text] >> >> Personally, I think it's a big mistake for the Apache Parent to >> generate these files automatically. >> They only apply to projects with no 3rd party dependencies or code. >> IMO the N&L files are too important to be auto-generated. >> >> Also, by using the auto-generated copies, SVN is left without any N&L >> files at the head of the tree. >> >> I would urge taglibs to use local copies of N&L files which can be >> properly maintained in SVN, and ignore the auto-generated ones. >> >>> there is small difference: >>> NOTICE: >>> Copyright 2000-2012 The Apache Software Foundation >>> NOTICE.txt: >>> Copyright 2009-2012 The Apache Software Foundation >>> >>> Is <inceptionYear> in pom.xml correct (2000) ? >>> >>> >>> 2. Looking at site.xml in source bundle and current site at >>> http://tomcat.apache.org/taglibs/ >>> >>> - I do not see a link to http://www.apache.org/licenses/ >>> - I do not see a link to http://tomcat.apache.org/security.html >>> >>> 3. commons-skin dependency says v.2. I see that there is v.3 at Maven >>> Central. >>> >>> >>> [x] +1 to go, but I think v2 will be needed before we release any of >>> the taglibs. >>> >>> It is hard to judge without looking at a site generated from this parent >>> pom. >>> >>> Best regards, >>> Konstantin Kolinko >>> >>> >>>> On Feb 28, 2012, at 12:12 PM, Mladen Turk wrote: >>>> >>>>> On 02/28/2012 08:57 PM, sebb wrote: >>>>>> On 28 February 2012 16:43, Mladen Turk<mt...@apache.org> wrote: >>>>>>> >>>>>>> Although not sure why you have LICENSE and LICENSE.txt as well >>>>>>> as NOTICE and NOTICE.txt with the same content >>>>>> >>>>>> That is probably caused by the Apache POM, which tries to be helpful >>>>>> by adding the N&L for you. >>>>>> >>>>> >>>>> Right, that should be the cause. >>>>> >>>>>> We had to disable that part in Commons, because we don't use the same >>>>>> naming convention (and the AP does not allow for the names to be >>>>>> changed). >>>>>> >>>>> >>>>> Whatever... Think that this should be easy to solve. >>>>> Just rm extra files if maven will add them automatically >>>>> and the content is satisfactory. >>>>> >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org >>> For additional commands, e-mail: dev-h...@tomcat.apache.org >>> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org >> For additional commands, e-mail: dev-h...@tomcat.apache.org >> > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
