On 23/01/2014 09:00, Mark Thomas wrote: > On 22/01/2014 22:03, Rémy Maucherat wrote: >> 2014/1/22 Mark Thomas <ma...@apache.org> > >>> I'll see what folks think of the patch so far and maybe explore the >>> entry/exit option as well. >>> >> The first patch however looks more complicated than the "dumb" way IMO. > > The variation of the code that needs to be run (return value / no return > value, different checked exceptions) adds most of the complication. > > I think I'll try, as you put it, a dumb version of the same patch and > see what it looks like.
http://people.apache.org/~markt/dev/2014-01-23-tccl-tc8-v2.patch It was easier to write, removes more code and the result is easier to read. Unless there are objections I plan to commit this along with some additional work to migrate other code that is currently doing this itself. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
