On Tue, Mar 29, 2016 at 1:32 PM, Romain Manni-Bucau [via TomEE & OpenEJB] < ml-node+s979440n4677988...@n4.nabble.com> wrote:
> > Sorry, what is a "jsf double stack" exactly? > > Going twice in the JSF stack in a single request - not sure there is a > name ;) > Ah, okay thanks for the explanation. I don't know what the term would be either. > > Do you mean the include of a JSF resource by a SAM? E.g. this test: > > > > > https://github.com/javaee-samples/javaee7-samples/blob/master/jaspic/dispatching-jsf-cdi/src/test/java/org/javaee7/jaspictest/dispatching/JSFCDIIncludeTest.java > > > > Yes > Well, in that case JSF is only invoked once. A JSF based resource is included in the response once, but the target resource is a plain Servlet. I do have this test on my radar for some time now and was thinking how to fix it in Mojarra, or whether I should perhaps remove this test. > > > > >> fixed on master - > > > > > > Do you mean fixed in this commit? > > > https://github.com/rmannibucau/javaee7-samples/commit/301118feaad47996345a5778a5022c3e427e1e7c > > > > No was tomee master for this one;). MyFaces will get the fix too but > it is not really specified AFAIK > > Also pushed to my branch fixes for angularjs sample which now runs > too, this one was hibernate specific for JPA layer, not portable on > JAXRS layer and frontend tests were not working for me cause htmlunit > doesn't support enough js + the modal was not correctly interpreted > for it. > > > > > > >> so sometimes a > >> failure is not linked to the central feature of the sample :(. > >> > >> > > >> > > >> > On Mon, Mar 28, 2016 at 4:26 PM, Romain Manni-Bucau [via TomEE & > >> OpenEJB] > >> < > >> > >> > [hidden email] <http:///user/SendEmail.jtp?type=node&node=4677979&i=1>> > > >> wrote: > >> > > >> > > pushed my work on https://github.com/rmannibucau/javaee7-samples. > >> > > Several samples should pass and doesnt yet. Didn't check why but > can > >> > > just be a pom setup issue, implementation hypothesis (like > hardcoding > >> > > a h2/hibernate usage ;)) or something like that (typically a lot of > >> > > websocket tests are failing but we should pass them without hacking > >> > > tomee). > >> > > > >> > > Romain Manni-Bucau > >> > > @rmannibucau | Blog | Github | LinkedIn | Tomitriber > >> > > > >> > > > >> > > 2016-03-28 10:56 GMT+02:00 Romain Manni-Bucau <[hidden email] > >> > > <http:///user/SendEmail.jtp?type=node&node=4677977&i=0>>: > >> > > > >> > > > > >> > > > Le 28 mars 2016 04:44, "Arjan Tijms" <[hidden email] > >> > > <http:///user/SendEmail.jtp?type=node&node=4677977&i=1>> a écrit : > >> > > >> > >> > > >> On Sun, Mar 27, 2016 at 11:33 AM, Romain Manni-Bucau [via TomEE > & > >> > > OpenEJB] > >> > > >> < > >> > > >> [hidden email] <http:// > >> /user/SendEmail.jtp?type=node&node=4677977&i=2>> > >> > >> > > wrote: > >> > > >> > >> > > >> > Normally master is deployed each night but sometimes it doesnt > >> work > >> > > so > >> > > >> > should be. > >> > > >> > > >> > > >> > >> > > >> Ok, thanks! > >> > > >> > >> > > >> > >> > > >> > > >> > > >> > Ran some ee samples but some of them are not portable or rely > too > >> > > much > >> > > >> > on > >> > > >> > proprietary features. Will try to push my tomee branch next > week. > >> > > >> > > >> > > >> > >> > > >> The JASPIC tests from the Java EE 7 samples project should be as > >> > > portable > >> > > >> as one can get. Some servers insist on activating JASPIC > (Liberty, > >> > > JBoss), > >> > > >> or having proprietary group to role mapping in place (almost all > >> > > servers > >> > > >> except JBoss). > >> > > >> > >> > > >> Or did you mean general EE samples from that project and not > just > >> the > >> > > >> JASPIC ones? If so, a PR to make them more portable and remove > >> reliance > >> > > on > >> > > >> proprietary features would be appreciated ;) > >> > > >> > >> > > > > >> > > > Both by side effects mainly. Wait 1-2 days and i ll push once my > >> review > >> > >> > > > done;) > >> > > > > >> > > > > >> > > >> > >> > > >> > > >> > > >> > > > >> > > >> > > > >> > > >> > > On Fri, Mar 25, 2016 at 2:45 PM, Romain Manni-Bucau [via > TomEE > >> & > >> > > >> > OpenEJB] > >> > > >> > < > >> > > >> > > >> > > >> > > [hidden email] > >> > > >> > > <http:///user/SendEmail.jtp?type=node&node=4677974&i=1>> > >> > > >> > wrote: > >> > > >> > > > >> > > >> > > > Hi > >> > > >> > > > > >> > > >> > > > answering there even if a bit old but google find this > thread > >> so > >> > >> > > >> > > > trying to keep threads consistent... > >> > > >> > > > > >> > > >> > > > TomEE master is on Tomcat 8.5.x so inherits from Jaspic > now. > >> > > >> > > > > >> > > >> > > > Romain Manni-Bucau > >> > > >> > > > @rmannibucau | Blog | Github | LinkedIn | Tomitriber > >> > > >> > > > > >> > > >> > > > > >> > > >> > > > 2013-09-03 5:11 GMT+02:00 Anthony Fryer <[hidden email] > >> > > >> > > > <http:///user/SendEmail.jtp?type=node&node=4677971&i=0>>: > >> > > >> > > > > >> > > >> > > > > I was looking for exactly this functionality 2 weeks ago > to > >> use > >> > >> > > >> > > > > with > >> > > >> > > > TomEE. > >> > > >> > > > > I ended up having to write a tomcat AuthenticatorValve > and > >> a > >> > > >> > > > > custom > >> > > >> > > > Realm > >> > > >> > > > > class to implement the same thing you've done with your > >> > > standard > >> > > >> > JASPIC > >> > > >> > > > > implementation (using SocialAuth as you have done). It > >> would > >> > > be > >> > > >> > great > >> > > >> > > > to > >> > > >> > > > > have this, especially for the Social Authentication > >> scenario. > >> > > Any > >> > > >> > > > situation > >> > > >> > > > > where you want to access the HttpServletRequest and > >> > > >> > HttpServletResponse > >> > > >> > > > to > >> > > >> > > > > perform redirects and callbacks in the authentication > "work > >> > > flow" > >> > > >> > would > >> > > >> > > > > benefit from this. > >> > > >> > > > > > >> > > >> > > > > > >> > > >> > > > > > >> > > >> > > > > -- > >> > > >> > > > > View this message in context: > >> > > >> > > > > >> > > >> > > >> > > >> > > >> > > >> > > >> > > > >> > >> > http://openejb.979440.n4.nabble.com/Consider-support-for-the-Servlet-profile-of-JSR-196-JASPIC-in-TomEE-tp4660480p4664957.html > >> > >> > > >> > > > > Sent from the OpenEJB Dev mailing list archive at > >> Nabble.com. > >> > > >> > > > > >> > > >> > > > > >> > > >> > > > ------------------------------ > >> > > >> > > > If you reply to this email, your message will be added to > the > >> > > >> > discussion > >> > > >> > > > below: > >> > > >> > > > > >> > > >> > > > > >> > > >> > > >> > > >> > > >> > > >> > > >> > > > >> > >> > http://tomee-openejb.979440.n4.nabble.com/Consider-support-for-the-Servlet-profile-of-JSR-196-JASPIC-in-TomEE-tp4660480p4677971.html > >> > >> > > >> > > > To unsubscribe from Consider support for the Servlet > profile > >> of > >> > > JSR > >> > > >> > 196 > >> > > >> > > > (JASPIC) in TomEE, click here > >> > > >> > > > < > >> > > >> > > >> > > >> > > > . > >> > > >> > > > NAML > >> > > >> > > > < > >> > > >> > > >> > > >> > > >> > > >> > > >> > > > >> > >> > http://tomee-openejb.979440.n4.nabble.com/template/NamlServlet.jtp?macro=macro_viewer&id=instant_html%21nabble%3Aemail.naml&base=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespace&breadcrumbs=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml > >> > >> > > >> > > > >> > > >> > > > > >> > > >> > > > >> > > >> > > > >> > > >> > > > >> > > >> > > > >> > > >> > > -- > >> > > >> > > View this message in context: > >> > > >> > > >> > > >> > > >> > > >> > > >> > > > >> > >> > http://tomee-openejb.979440.n4.nabble.com/Consider-support-for-the-Servlet-profile-of-JSR-196-JASPIC-in-TomEE-tp4660480p4677972.html > >> > >> > > >> > > Sent from the TomEE Dev mailing list archive at Nabble.com. > >> > > >> > > >> > > >> > > >> > > >> > ------------------------------ > >> > > >> > If you reply to this email, your message will be added to the > >> > > discussion > >> > > >> > below: > >> > > >> > > >> > > >> > > >> > > >> > > >> > > > >> > >> > http://tomee-openejb.979440.n4.nabble.com/Consider-support-for-the-Servlet-profile-of-JSR-196-JASPIC-in-TomEE-tp4660480p4677974.html > >> > >> > > >> > To unsubscribe from Consider support for the Servlet profile > of > >> JSR > >> > > 196 > >> > > >> > (JASPIC) in TomEE, click here > >> > > >> > > >> > > >> > < > >> > > >> > . > >> > > >> > NAML > >> > > >> > > >> > > >> > < > >> > > > >> > >> > http://tomee-openejb.979440.n4.nabble.com/template/NamlServlet.jtp?macro=macro_viewer&id=instant_html%21nabble%3Aemail.naml&base=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespace&breadcrumbs=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml > >> > >> > > >> > > > >> > > >> > > >> > > >> > >> > > >> > >> > > >> > >> > > >> > >> > > >> -- > >> > > >> View this message in context: > >> > > >> > >> > > > >> > >> > http://tomee-openejb.979440.n4.nabble.com/Consider-support-for-the-Servlet-profile-of-JSR-196-JASPIC-in-TomEE-tp4660480p4677975.html > >> > > >> Sent from the TomEE Dev mailing list archive at Nabble.com. > >> > > > >> > > > >> > > ------------------------------ > >> > > If you reply to this email, your message will be added to the > >> discussion > >> > > below: > >> > > > >> > > > >> > >> > http://tomee-openejb.979440.n4.nabble.com/Consider-support-for-the-Servlet-profile-of-JSR-196-JASPIC-in-TomEE-tp4660480p4677977.html > >> > > To unsubscribe from Consider support for the Servlet profile of JSR > >> 196 > >> > > (JASPIC) in TomEE, click here > >> > > < > >> > >> > > . > >> > > NAML > >> > > < > >> > >> > http://tomee-openejb.979440.n4.nabble.com/template/NamlServlet.jtp?macro=macro_viewer&id=instant_html%21nabble%3Aemail.naml&base=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespace&breadcrumbs=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml > >> > > >> > > > >> > > >> > > >> > > >> > > >> > -- > >> > View this message in context: > >> > >> > http://tomee-openejb.979440.n4.nabble.com/Consider-support-for-the-Servlet-profile-of-JSR-196-JASPIC-in-TomEE-tp4660480p4677978.html > >> > Sent from the TomEE Dev mailing list archive at Nabble.com. > >> > >> > >> ------------------------------ > >> If you reply to this email, your message will be added to the > discussion > >> below: > >> > >> > http://tomee-openejb.979440.n4.nabble.com/Consider-support-for-the-Servlet-profile-of-JSR-196-JASPIC-in-TomEE-tp4660480p4677979.html > >> To unsubscribe from Consider support for the Servlet profile of JSR 196 > >> (JASPIC) in TomEE, click here > >> < > >> . > >> NAML > >> < > http://tomee-openejb.979440.n4.nabble.com/template/NamlServlet.jtp?macro=macro_viewer&id=instant_html%21nabble%3Aemail.naml&base=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespace&breadcrumbs=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml> > > >> > > > > > > > > > > -- > > View this message in context: > http://tomee-openejb.979440.n4.nabble.com/Consider-support-for-the-Servlet-profile-of-JSR-196-JASPIC-in-TomEE-tp4660480p4677984.html > > Sent from the TomEE Dev mailing list archive at Nabble.com. > > > ------------------------------ > If you reply to this email, your message will be added to the discussion > below: > > http://tomee-openejb.979440.n4.nabble.com/Consider-support-for-the-Servlet-profile-of-JSR-196-JASPIC-in-TomEE-tp4660480p4677988.html > To unsubscribe from Consider support for the Servlet profile of JSR 196 > (JASPIC) in TomEE, click here > <http://tomee-openejb.979440.n4.nabble.com/template/NamlServlet.jtp?macro=unsubscribe_by_code&node=4660480&code=YXJqYW4udGlqbXNAZ21haWwuY29tfDQ2NjA0ODB8LTM3MzU5NTg0OA==> > . > NAML > <http://tomee-openejb.979440.n4.nabble.com/template/NamlServlet.jtp?macro=macro_viewer&id=instant_html%21nabble%3Aemail.naml&base=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespace&breadcrumbs=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml> > -- View this message in context: http://tomee-openejb.979440.n4.nabble.com/Consider-support-for-the-Servlet-profile-of-JSR-196-JASPIC-in-TomEE-tp4660480p4677991.html Sent from the TomEE Dev mailing list archive at Nabble.com.