There is currently a checkstyle rule enforcing the header to ASLv2. In addition to java packages and groupId, the parent pom also needs to be updated so that it does not use any Tomitribe reference in there.
-- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Sat, Sep 9, 2017 at 10:15 AM, Mark Struberg <strub...@yahoo.de.invalid> wrote: > I really like both of them. > > But we should not forget to check the IP. > Is this a clean room implementation? Have there been substantial > contributions from others or does Tomitribe at least have a CLA for them? > > * As far as I've seen all of the committers are ASF TomEE committers, > right? check! > > * Just checked a few files, all of them are "Licensed to the Apache > Software Foundation (ASF) under one or more..." ALv2, so this is fine from > the beginning, even while not hosted at the ASF. David, are all files that > way? Just checked a few and they have all been fine. check! > > +1 > > LieGrue, > strub > > PS: Shedon Cooper might cause come trademark issues ;) > > > > > Am 08.09.2017 um 23:49 schrieb Jonathan Gallimore < > jonathan.gallim...@gmail.com>: > > > > Lol :-). > > > > Here's my vote for +1: Let’s do this! > > > > Thanks > > > > Jon > > > > On Fri, Sep 8, 2017 at 10:39 PM, David Blevins <david.blev...@gmail.com> > > wrote: > > > >> That would be the decent thing to do :) > >> > >> > >> -- > >> David Blevins > >> http://twitter.com/dblevins > >> http://www.tomitribe.com > >> > >>> On Sep 8, 2017, at 2:33 PM, John D. Ament <johndam...@apache.org> > wrote: > >>> > >>> +1 IF and ONLY IF Sheldon has a class named Cooper. > >>> > >>> On Sep 8, 2017 5:24 PM, "David Blevins" <david.blev...@gmail.com> > wrote: > >>> > >>>> Let’s put this up for a vote. Proposal: > >>>> > >>>> Should we accept the code donations of Sheldon and Chatterbox as part > of > >>>> the Apache TomEE project. > >>>> > >>>> - https://tomitribe.io/projects/sheldon > >>>> - https://tomitribe.io/projects/chatterbox > >>>> > >>>> They’ll be named Apache Sheldon and Apache Chatterbox respectively. > >> Maven > >>>> groupid and java packages up for discussion. (I have no preference) > >>>> > >>>> All votes welcome: > >>>> > >>>> +1: Let’s do this! > >>>> > >>>> +0: I don't feel strongly about it, but I'm okay with this. > >>>> > >>>> -0: I won't get in the way, but I'd rather we didn't do this. > >>>> > >>>> -1: I really don't like this, because [insert reason] > >>>> > >>>> I’ll leave this up for a week so people have time to vote. All votes > >> are > >>>> welcome from anyone. The more votes the better. > >>>> > >>>> > >>>> -- > >>>> David Blevins > >>>> http://twitter.com/dblevins > >>>> http://www.tomitribe.com > >>>> > >>>> > >> > >> > >
