since the 16th we pass tck - both tomee and openejb - but maybe snapshots are not up to date (bval and [weaver]
Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> | LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book <https://www.packtpub.com/application-development/java-ee-8-high-performance> Le ven. 24 août 2018 à 11:46, Roberto Cortez <radcor...@yahoo.com.invalid> a écrit : > Our last build was not passing the BVal TCK: > https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/828 < > https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8/builds/828> > > We had a couple of other issues related with some MP Tests and CDI, which > should be fixed. > > I’ll try to have a look into BVal. > > Cheers, > Roberto > > > On 24 Aug 2018, at 09:18, Romain Manni-Bucau <rmannibu...@gmail.com> > wrote: > > > > Le ven. 24 août 2018 à 10:17, Mark Struberg <strub...@yahoo.de.invalid> > a > > écrit : > > > >> One task to do is to provide feedback for Apache BVal 2.0. > >> > > > > Can you detail this one? I checked we were passing TCK with bval 2. > > > > > >> > >> And I would love to also take this as a chance to give a huge round of > >> applause to Matt Benson who most TomEE users - and even devs - probably > >> don‘t even know. > >> He is the big force behind BVal these days. > >> Right now he is doing a release of commons-weaver [1] which is used to > >> create all the doPrivileged blocks automagically. > >> After that we‘ll release BVal-2.0.0. > >> > >> Anybody is welcome to check out BVal and/or commons-weaver and help us > >> with this effort! > >> > >> LieGrue, > >> Strub > >> > >> > >> > >> [1] https://commons.apache.org/proper/commons-weaver/ > >> > >> Am 23.08.2018 um 20:43 schrieb David Blevins <david.blev...@gmail.com>: > >> > >>>> On Aug 22, 2018, at 3:08 PM, Roberto Cortez > <radcor...@yahoo.com.INVALID> > >> wrote: > >>>> > >>>> Great! Thank you. > >>>> > >>>> In the meanwhile, I will be looking into TomEE 8, so we can cut a > >> release from there as well. > >>> > >>> What issues are you looking into and is there any way people can help? > >>> > >>> > >>> -David > >>> > >>> > >>>>> On 22 Aug 2018, at 21:56, Jonathan Gallimore < > >> jonathan.gallim...@gmail.com> wrote: > >>>>> > >>>>> We now have a passing build for tomee-7.1.x, so I will attempt a > >> release > >>>>> there. TomEE 8 still has some build errors, so some eyes on that > would > >> be > >>>>> great. Ideally we want to release both and keep up the cadence with > >> both > >>>>> branches. > >>>>> > >>>>> This might take a couple of attempts so if you see some strange > commits > >>>>> going in and then being reverted, you know what's going on. > >>>>> > >>>>> Jon > >>>>> > >>>>> On Mon, Aug 20, 2018 at 10:49 PM Roberto Cortez > >> <radcor...@yahoo.com.invalid> > >>>>> wrote: > >>>>> > >>>>>> Ok, I was able to pinpoint and fix the failing tests. I’ve found the > >> fixes > >>>>>> done in TomEE 8, because of the flag change and made a couple of > >> cherry > >>>>>> picks. Here is the PR: https://github.com/apache/tomee/pull/152 < > >>>>>> https://github.com/apache/tomee/pull/152>. > >>>>>> > >>>>>> If we can merge it and run the build again, it would be great. > >>>>>> > >>>>>> Cheers, > >>>>>> Roberto > >>>>>> > >>>>>>> On 20 Aug 2018, at 17:38, Roberto Cortez > <radcor...@yahoo.com.INVALID > >>> > >>>>>> wrote: > >>>>>>> > >>>>>>> Apparently the issue with TomEE 7.1 is because of this: > >>>>>>> > >>>>>> > >> > https://github.com/apache/tomee/commit/76c9698a27ccbc4bb5970382846b570dc5f36793 > >>>>>> < > >>>>>> > >> > https://github.com/apache/tomee/commit/76c9698a27ccbc4bb5970382846b570dc5f36793 > >>>>>>> > >>>>>>> > >>>>>>> I’ve changed the openejb.scan.webapp.container default to true, so > >> the > >>>>>> MP libs are scanned for CDI to start their extensions. That change > >> was also > >>>>>> done in TomEE 8, and the core tests pass there. Not sure why yet. > >>>>>>> > >>>>>>> Cheers, > >>>>>>> Roberto > >>>>>>> > >>>>>>>> On 20 Aug 2018, at 13:47, Romain Manni-Bucau < > rmannibu...@gmail.com > >>> > >>>>>> wrote: > >>>>>>>> > >>>>>>>> https://ci.apache.org/builders/tomee-trunk-ubuntu-jvm8 > >>>>>>>> https://ci.apache.org/builders/tomee-7.1.x-ubuntu-jvm8 > >>>>>>>> > >>>>>>>> Romain Manni-Bucau > >>>>>>>> @rmannibucau <https://twitter.com/rmannibucau> | Blog > >>>>>>>> <https://rmannibucau.metawerx.net/> | Old Blog > >>>>>>>> <http://rmannibucau.wordpress.com> | Github < > >>>>>> https://github.com/rmannibucau> | > >>>>>>>> LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book > >>>>>>>> < > >>>>>> > >> > https://www.packtpub.com/application-development/java-ee-8-high-performance > >>>>>>> > >>>>>>>> > >>>>>>>> > >>>>>>>> Le lun. 20 août 2018 à 14:38, Matthew Broadhead > >>>>>>>> <matthew.broadh...@nbmlaw.co.uk.invalid> a écrit : > >>>>>>>> > >>>>>>>>> are we using jenkins for CI? is there an interface to see the > >> status > >>>>>> of > >>>>>>>>> builds without logging in? > >>>>>>>>> > >>>>>>>>>> On 20/08/18 12:25, Jonathan Gallimore wrote: > >>>>>>>>>> We ought to get a green build on the CI, or at least some > >> agreement to > >>>>>>>>>> ignore those failures for a release. Its hard enough releasing > >> when > >>>>>> there > >>>>>>>>>> is a green build and the feedback is "the tests fail on my box" > ( > >>>>>>>>>> > >>>>>>>>> > >>>>>> > >> > http://tomee-openejb.979440.n4.nabble.com/VOTE-Apache-TomEE-7-0-5-td4684159.html > >>>>>>>>> ). > >>>>>>>>>> I can confirm the failures in openejb-core on tomee-7.1.x. They > >> fail > >>>>>> here > >>>>>>>>>> for me too. The build was green on the 7.0.5 release, so I'm > >> currently > >>>>>>>>>> doing a git-bisect there to see what's changed. > >>>>>>>>>> > >>>>>>>>>> Jon > >>>>>>>>>> > >>>>>>>>>> On Mon, Aug 20, 2018 at 11:19 AM, Roberto Cortez < > >>>>>>>>>> radcor...@yahoo.com.invalid> wrote: > >>>>>>>>>> > >>>>>>>>>>> Hi Jon, > >>>>>>>>>>> > >>>>>>>>>>> I did run the MP tests in TomEE 8 and all of them pass in my > box. > >>>>>> I’ll > >>>>>>>>> try > >>>>>>>>>>> a few more runs to see what happens. > >>>>>>>>>>> > >>>>>>>>>>> Cheers, > >>>>>>>>>>> Roberto > >>>>>>>>>>> > >>>>>>>>>>>> On 20 Aug 2018, at 09:27, Jonathan Gallimore < > >>>>>>>>>>> jonathan.gallim...@gmail.com> wrote: > >>>>>>>>>>>> Ok, its Monday. Just checking on our status: > >>>>>>>>>>>> > >>>>>>>>>>>> Master: > >>>>>>>>>>>> https://ci.apache.org/builders/tomee-trunk-ubuntu- > >>>>>>>>>>> jvm8/builds/826/steps/test/logs/stdio/text > >>>>>>>>>>>> We have some test failures, mostly on the CDI TCK and some on > >>>>>>>>>>> MicroProfile, > >>>>>>>>>>>> and some Arquillian. > >>>>>>>>>>>> > >>>>>>>>>>>> 7.1.x: This looks even worse, with failures in openejb-core - > >>>>>>>>>>>> https://ci.apache.org/builders/tomee-7.1.x-ubuntu- > >>>>>>>>>>> jvm8/builds/0/steps/test/logs/stdio/text > >>>>>>>>>>>> I'm happy to look at some of these, but can't fix it all on my > >> own. > >>>>>>>>>>>> @Roberto - you probably know those changes best. If you can > >> look at > >>>>>>>>> some, > >>>>>>>>>>>> that would be much appreciated. Any other help is appreciated. > >>>>>>>>>>>> > >>>>>>>>>>>> On the bval snapshot side, we've previously rolled our own > >> releases > >>>>>> of > >>>>>>>>>>>> these dependencies where we've needed to in the past. OpenJPA > >>>>>> springs > >>>>>>>>> to > >>>>>>>>>>>> mind. Unless a bval release is imminent, I'd suugest we take > >> that > >>>>>>>>>>> approach > >>>>>>>>>>>> to work around this. We've been talking about improving our > >> release > >>>>>>>>>>> cadence > >>>>>>>>>>>> for a while, we should come through on that. > >>>>>>>>>>>> > >>>>>>>>>>>> Jon > >>>>>>>>>>>> > >>>>>>>>>>>> On Wed, Aug 15, 2018 at 11:30 PM, Mark Struberg > >>>>>>>>>>> <strub...@yahoo.de.invalid> > >>>>>>>>>>>> wrote: > >>>>>>>>>>>> > >>>>>>>>>>>>> We first need to check if we have all deps ready. > >>>>>>>>>>>>> Afair bval2 is not yet released. > >>>>>>>>>>>>> We have to roll this first. > >>>>>>>>>>>>> > >>>>>>>>>>>>> LieGrue, > >>>>>>>>>>>>> Strub > >>>>>>>>>>>>> > >>>>>>>>>>>>>> Am 15.08.2018 um 17:48 schrieb Jonathan Gallimore < > >>>>>>>>>>>>> jonathan.gallim...@gmail.com>: > >>>>>>>>>>>>>> I've merged these in, and I have updated the buildbot config > >> to > >>>>>> build > >>>>>>>>>>>>>> 1.7.x, 7.0.x 7.1.x and master. I'll be applying that in a > >> moment. > >>>>>>>>>>>>>> > >>>>>>>>>>>>>> Jon > >>>>>>>>>>>>>> > >>>>>>>>>>>>>> On Wed, Aug 15, 2018 at 2:11 PM, Roberto Cortez > >>>>>>>>>>>>> <radcor...@yahoo.com.invalid > >>>>>>>>>>>>>>> wrote: > >>>>>>>>>>>>>>> Hey Jon, > >>>>>>>>>>>>>>> > >>>>>>>>>>>>>>> Sure. Please have a look into these: > >>>>>>>>>>>>>>> > >>>>>>>>>>>>>>> https://github.com/apache/tomee/pull/145 < > >>>>>>>>> https://github.com/apache/ > >>>>>>>>>>>>>>> tomee/pull/145> > >>>>>>>>>>>>>>> https://github.com/apache/tomee/pull/141 < > >>>>>>>>> https://github.com/apache/ > >>>>>>>>>>>>>>> tomee/pull/141> > >>>>>>>>>>>>>>> https://github.com/apache/tomee/pull/146 < > >>>>>>>>> https://github.com/apache/ > >>>>>>>>>>>>>>> tomee/pull/146> > >>>>>>>>>>>>>>> https://github.com/apache/tomee/pull/142 < > >>>>>>>>> https://github.com/apache/ > >>>>>>>>>>>>>>> tomee/pull/142> > >>>>>>>>>>>>>>> > >>>>>>>>>>>>>>> Let me know if I can help. > >>>>>>>>>>>>>>> > >>>>>>>>>>>>>>> Thank you. > >>>>>>>>>>>>>>> > >>>>>>>>>>>>>>> Cheers, > >>>>>>>>>>>>>>> Roberto > >>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>> On 15 Aug 2018, at 10:17, Jonathan Gallimore < > >>>>>>>>>>>>>>> jonathan.gallim...@gmail.com> wrote: > >>>>>>>>>>>>>>>> I push out a snapshot ahead of time, for sure. I'll check > >> our > >>>>>>>>>>> buildbot > >>>>>>>>>>>>>>> and > >>>>>>>>>>>>>>>> see if I can hook up something that runs daily. > >>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>> Roberto - do you need some stuff merging in? > >>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>> On Wed, 15 Aug 2018, 08:48 Matthew Broadhead, > >>>>>>>>>>>>>>>> <matthew.broadh...@nbmlaw.co.uk.invalid> wrote: > >>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>> previously Mark did a snapshot binary of TomEE 8 so we > >> could > >>>>>>>>>>> download > >>>>>>>>>>>>>>>>> and test with our projects. are we releasing directly or > >> will > >>>>>> we > >>>>>>>>>>> get > >>>>>>>>>>>>> a > >>>>>>>>>>>>>>>>> chance to try the snapshot first? are there nightly > builds > >>>>>>>>>>> somewhere? > >>>>>>>>>>>>>>>>>> On 15/08/18 00:13, Jonathan Gallimore wrote: > >>>>>>>>>>>>>>>>>> We discussed in the the thread "Goal - release this week > >> and > >>>>>> very > >>>>>>>>>>>>>>>>>> frequently thereafter" releasing this week, and I'm > >>>>>> definitely up > >>>>>>>>>>> for > >>>>>>>>>>>>>>>>> going > >>>>>>>>>>>>>>>>>> faster with our release cadence. > >>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>> With that in mind, I'd like to kick off a release of > >> TomEE 8 > >>>>>> and > >>>>>>>>>>>>> 7.1. I > >>>>>>>>>>>>>>>>> can > >>>>>>>>>>>>>>>>>> do this on Monday. Is there anything that needs merging > >> in? > >>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>> Jon > >>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>> > >>>>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>> > >>>>>>>>> > >>>>>>> > >>>>>> > >>>>>> > >>>> > >>> > >> > >
