Yes, I'll get that backported! Cheers
Jon On Thu, Dec 13, 2018 at 8:52 AM Wiesner, Martin < martin.wies...@hs-heilbronn.de> wrote: > Hi Jon, > > TOMEE-2234 has originally been reported as a bug for 1.7.3 and 7.0.5. > Thus, I think it should be fixed at least at on both 7.x branches. Could > you merge a backport of these changes to 1.7.x, 7.0.x and/or 7.1.x > maintenance branches? If conducted it will compatible with the original > report and we’ll fix it consistently with the 8.0.x master branch. > > In this context, I'll wait with resolving this issue in JIRA for some > days/weeks. > > Best > Martin > — > https://twitter.com/mawiesne > > > Am 12.12.2018 um 11:46 schrieb Jonathan Gallimore < > jonathan.gallim...@gmail.com>: > > Still testing, but here's the change: > https://github.com/apache/tomee/pull/272. Any feedback is welcome. > > Jon > > On Wed, Dec 12, 2018 at 10:29 AM Jonathan Gallimore < > jonathan.gallim...@gmail.com> wrote: > > I found the issue here, and fixed it. I need to check to ensure that the > change doesn't affect the wire protocol - I'm _fairly_ sure it doesn't, but > we'd need to discuss how to handle it, if it did. I should have a PR up for > review later today. > > Jon > > > > On Tue, Dec 11, 2018 at 2:34 PM Jonathan Gallimore < > jonathan.gallim...@gmail.com> wrote: > > I added a comment to the JIRA, but I'll follow up here too. I started > writing a test for this, and made a couple of small changes: > > * flipped your beans from remote to local > * added a servlet rather than a main > * introduced <ejb-local-ref> in ejb-jar.xml and web.xml so they can be > looked up via java:comp/env as opposed to the global JNDI name > put everything in a .war as opposed to .ear > > ... and it works. > > Generated .war file and source attached. I'm not entirely sure which of > my changes has enabled it to work - my current guess is its the remote -> > local change, but I'll dig into each one. > > Interesting problem - thanks for reporting it! > > Jon > > On Mon, Dec 10, 2018 at 7:43 PM Jonathan Gallimore < > jonathan.gallim...@gmail.com> wrote: > > Hi all > > I noticed this come in on JIRA: > https://issues.apache.org/jira/browse/TOMEE-2234 > > Seems we have an issue returning more than 256 entities from a BMP > finder. Given that I've worked in and around this area, I'd like to work on > it. I'll assign it to me, but if you had a burning desire to tackle it, let > me know. > > Thanks > > Jon > > > >
