I created a pull request, https://github.com/apache/tomee/pull/343 New maven project tomee-config is introduced with single class, TomEESystemConfig. This will include all system properties for tomee.* Also updated TomcatWebAppBuilder to remove some tomee.* properties and use the config class provided. Need to remove all others from the code base and use this class. Can you please check?
On Wed, Jan 2, 2019 at 1:31 PM Jean-Louis Monteiro <[email protected]> wrote: > Agreed. For such a critical and low level need on the system, I'm not so > fan about creating a hard dependency on a spec and an implementation. > -- > Jean-Louis Monteiro > http://twitter.com/jlouismonteiro > http://www.tomitribe.com > > > On Wed, Jan 2, 2019 at 11:26 AM Roberto Cortez <[email protected] > > > wrote: > > > I think we should stay away from MP Config for now. > > > > TomEE does a lot more regarding substitution and config on several places > > that MP Config doesn’t support. > > > > > On 2 Jan 2019, at 09:55, Bruno Baptista <[email protected]> wrote: > > > > > > Sounds like a good plan. :) > > > > > > Bruno Baptista > > > https://twitter.com/brunobat_ <https://twitter.com/brunobat_> > > > > > > On 02/01/19 09:47, Gurkan Erdogdu wrote: > > >> For me, using services-jar.xml approach is not so visible to users. > All > > >> defaults are configured in this file and packaged within JAR file. > Users > > >> are not able to read the parameter explanation from services-jar.xml > > files. > > >> Also, services.-jar.xml is somebit different from using the system > > >> properties to turn-on/off something. I am also thinking to introduce > > YAML > > >> based configuration. > > >> > > >> But first step is to centralise all of these system parameters into > two > > >> classes. Maybe, we will see that some of them are unnecessary etc. > > >> > > >> On Wed, Jan 2, 2019 at 12:44 PM Bruno Baptista <[email protected]> > > wrote: > > >> > > >>> Yes, there is. > > >>> > > >>> This is also the most basic MP spec and nothing prevents us from > using > > >>> it everywhere. > > >>> > > >>> There might be Jakarta EE restrictions in how to handle > configurations > > >>> that need to be assessed. > > >>> > > >>> Overall, I think that if we are going to mess with configs, we should > > >>> use state of the art. > > >>> > > >>> Cheers > > >>> > > >>> Bruno Baptista > > >>> https://twitter.com/brunobat_ > > >>> > > >>> > > >>> On 02/01/19 09:35, Jean-Louis Monteiro wrote: > > >>>> I think with microprofile-config we may have a chicken and the egg > > >>> problem, > > >>>> isn't it? > > >>>> -- > > >>>> Jean-Louis Monteiro > > >>>> http://twitter.com/jlouismonteiro > > >>>> http://www.tomitribe.com > > >>>> > > >>>> > > >>>> On Wed, Jan 2, 2019 at 10:30 AM Bruno Baptista <[email protected]> > > >>> wrote: > > >>>>> Hi Gurkan, > > >>>>> > > >>>>> I agree we have a problem with the documentation of the different > > >>>>> properties and that we need to improve it. > > >>>>> > > >>>>> Doing the inventory and using the proposed syntax looks ok to me > but > > I > > >>>>> also think we should go even further. > > >>>>> > > >>>>> How about to migrate all the properties to use microprofile-config? > > >>>>> > > >>>>> Cheers. > > >>>>> > > >>>>> Bruno Baptista > > >>>>> https://twitter.com/brunobat_ > > >>>>> > > >>>>> > > >>>>> On 02/01/19 07:20, Gurkan Erdogdu wrote: > > >>>>>> Hello > > >>>>>> There are lots of known and unknown system properties in the > current > > >>> code > > >>>>>> base. I would like to introduce TomEESystemProperties and > > >>>>>> OpenEJBSystemProperties classes to hold these system property > > constants > > >>>>> and > > >>>>>> provide clear comment what it does. For example: > > >>>>>> > > >>>>>> class TomEESystemProperties{ > > >>>>>> public static final String TOMEE_FORCE_RELOADABLE = > > >>>>>> "tomee.force-reloadable"; > > >>>>>> .... > > >>>>>> } > > >>>>>> > > >>>>>> class OpenEJBSystemProperties{ > > >>>>>> public static final String OPENEJB_CROSSCONTEXT_PROPERTY = > > >>>>>> "openejb.crosscontext"; > > >>>>>> .... > > >>>>>> } > > >>>>>> > > >>>>>> WDYT? > > >>>>>> Regards. > > >>>>>> Gurkan > > >>>>>> > > > > >
