On Fri, Jan 4, 2019 at 6:39 PM Ivan Junckes Filho <[email protected]> wrote:
> Hey guys, can someone provide me the way to check if my PR is green? > Yep, run the build on your branch :-). I run builds on PRs when I review them. If you don't want to run the full build, you could run tests that are relevant to your change. If you need guidance on possible impacts of a PR, please ask :). Also, I wouldn't be scared of things being merged in and the build breaking. The key thing is to check it, and help fix it if there is a problem. The current CI builds on buildbot are available from here: https://ci.apache.org/buildbot.html > Also, now that apache has migrated to gitbox, is there a way to integrate > the build with github? > This wasn't a pre-requisite of being able to build PRs on a CI. If someone wants to have a go at setting up something to run against PRs on Travis or on ASF infrastructure, please do go for it. Its not something we can just "switch on" though I'm afraid. We do also need to be mindful that we have 27 open PRs and a build that takes 5 hours to run fully - so if we do setup something like this, it will consume a fair bit of resource. Jon > > On Thu, Jan 3, 2019 at 10:03 AM Jean-Louis Monteiro < > [email protected]> wrote: > > > That'd be great indeed > > > > -- > > Jean-Louis Monteiro > > http://twitter.com/jlouismonteiro > > http://www.tomitribe.com > > > > > > On Thu, Jan 3, 2019 at 12:26 PM Roberto Cortez > <[email protected] > > > > > wrote: > > > > > Maybe Bruno would like to work on that, since he is heavily involved > with > > > the EG and he did the integration for the last version? > > > > > > > On 3 Jan 2019, at 11:16, Jean-Louis Monteiro < > [email protected] > > > > > > wrote: > > > > > > > > Ok, looks like the build is back to stable. > > > > There are 2 other votes currently. I'll do an update when the vote is > > > > closed. > > > > > > > > Meanwhile, we need an action plan for fault tolerance. We need to > > > > investigate what happened or if we need to rework the integration. > > > > > > > > -- > > > > Jean-Louis Monteiro > > > > http://twitter.com/jlouismonteiro > > > > http://www.tomitribe.com > > > > > > > > > > > > On Wed, Jan 2, 2019 at 7:57 PM Bruno Baptista <[email protected]> > > > wrote: > > > > > > > >> I think there's a vote for a minor release fixing an issue there. > > > >> > > > >> Bruno Baptista > > > >> https://twitter.com/brunobat_ > > > >> > > > >> > > > >> On 02/01/19 18:56, Roberto Cortez wrote: > > > >>> The OpenTracing update was also failing the TCK. I’ve reverted it > > back > > > >> until we figure out what is going on. > > > >>> > > > >>>> On 2 Jan 2019, at 16:50, Roberto Cortez > <[email protected] > > > > > > >> wrote: > > > >>>> > > > >>>> It seems to fail intermittently. It took me a few tries to make it > > > >> fail. On the latest buildbot it seems fine. > > > >>>> > > > >>>> Not sure if it was like this before or if it was something we did. > > > >>>> > > > >>>>> On 2 Jan 2019, at 12:14, Jean-Louis Monteiro < > > > [email protected]> > > > >> wrote: > > > >>>>> > > > >>>>> [ERROR] Failures: > > > >>>>> [ERROR] LegacyServerTest.test:208->assertBalance:219 Bad number > > of > > > >>>>> invocations for the bean "green". expected:<2> but was:<1> > > > >>>>> > > > >>>>> -- > > > >>>>> Jean-Louis Monteiro > > > >>>>> http://twitter.com/jlouismonteiro > > > >>>>> http://www.tomitribe.com > > > >>>>> > > > >>>>> > > > >>>>> On Wed, Jan 2, 2019 at 1:14 PM Jean-Louis Monteiro < > > > >> [email protected]> > > > >>>>> wrote: > > > >>>>> > > > >>>>>> I also get this one locally > > > >>>>>> > > > >>>>>> -- > > > >>>>>> Jean-Louis Monteiro > > > >>>>>> http://twitter.com/jlouismonteiro > > > >>>>>> http://www.tomitribe.com > > > >>>>>> > > > >>>>>> > > > >>>>>> On Wed, Jan 2, 2019 at 1:05 PM Roberto Cortez > > > >> <[email protected]> > > > >>>>>> wrote: > > > >>>>>> > > > >>>>>>> One issue at least was with the Safeguard upgrade. I’ve > reverted > > it > > > >> back. > > > >>>>>>> Lets see if this helps. > > > >>>>>>> > > > >>>>>>>> On 2 Jan 2019, at 11:33, Roberto Cortez > > > <[email protected] > > > >>> > > > >>>>>>> wrote: > > > >>>>>>>> Yeah, just noticed it as well. Was about to send a message > too. > > I > > > >> can > > > >>>>>>> have a look. > > > >>>>>>>>> On 2 Jan 2019, at 11:00, Jean-Louis Monteiro < > > > >> [email protected]> > > > >>>>>>> wrote: > > > >>>>>>>>> Ok, looks like we are back to red. > > > >>>>>>>>> Someone working on it? > > > >>>>>>>>> -- > > > >>>>>>>>> Jean-Louis Monteiro > > > >>>>>>>>> http://twitter.com/jlouismonteiro > > > >>>>>>>>> http://www.tomitribe.com > > > >>>>>>>>> > > > >>>>>>>>> > > > >>>>>>>>> On Fri, Dec 21, 2018 at 12:59 AM Roberto Cortez > > > >>>>>>> <[email protected]> > > > >>>>>>>>> wrote: > > > >>>>>>>>> > > > >>>>>>>>>> By the way, lets try to keep it that way :) > > > >>>>>>>>>> > > > >>>>>>>>>>> On 20 Dec 2018, at 20:48, César Hernández Mendoza < > > > >>>>>>> [email protected]> > > > >>>>>>>>>> wrote: > > > >>>>>>>>>>> Nice work guys! > > > >>>>>>>>>>> > > > >>>>>>>>>>> El jue., 20 dic. 2018 a las 13:55, Frankie (< > > > >> [email protected] > > > >>>>>>>> ) > > > >>>>>>>>>>> escribió: > > > >>>>>>>>>>> > > > >>>>>>>>>>>> Great! Well Done! > > > >>>>>>>>>>>> > > > >>>>>>>>>>>> Frankie > > > >>>>>>>>>>>> > > > >>>>>>>>>>>> > > > >>>>>>>>>>>> > > > >>>>>>>>>>>> -- > > > >>>>>>>>>>>> Sent from: > > > >>>>>>>>>>>> > > > >> http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html > > > >>>>>>>>>>>> > > > >>>>>>>>>>> > > > >>>>>>>>>>> -- > > > >>>>>>>>>>> Atentamente: > > > >>>>>>>>>>> César Hernández Mendoza. > > > >>>>>>>>>> > > > >>>>>>> > > > >> > > > > > > > > >
