Hi Cesar I've merged in your PR, thanks for the fix.
Jon On Tue, Feb 12, 2019 at 8:42 AM Daniel Cunha <daniels...@apache.org> wrote: > Hi César, > > since we have the option for runtest: > -U,--update Mvn update snapshots > > it really doesn't need to exists it implicit on the maven command, it > should be optional. So I can use the -U if I do: ./runtest -U script > > Good catch! > > > Em ter, 12 de fev de 2019 às 00:24, César Hernández Mendoza < > cesargu...@gmail.com> escreveu: > > > I opened this PR https://github.com/apache/tomee-tck/pull/9 to: > > > > 1) fix a typo in pom.xml > > 2) rollback to tomee and openejb 8.0.0-snapshot because that facilitates > > local debug and testing while trying to fix tests. > > 3) Removed from ./runtest shellscript the implicit -U flag for mvn. This > > was causing a strange behavior when trying to debug locally because even > if > > you don't provide -U in the ./runtest script, the -U was always implicit > > inside the script. > > > > Can someone of the committers please review the PR. > > > > El vie., 8 feb. 2019 a las 17:08, César Hernández Mendoza (< > > cesargu...@gmail.com>) escribió: > > > > > I'm having issues trying to debug the failing test described in my > > > previous email. > > > > > > Does TomEE-TCK has a way to debug a specific TomEE version from my > > > ~/.m2/repository without downloading TomEE from the internet? > > > > > > I noticed that the current tomee-tck pom [1] is using version 8.0.0-M2 > > > for both <openejb.version> and <tomee.version> > > > On my local tomee-tck I changed this to 8.0.0-SNAPSHOT, which is the > > > version I generate from my local tomee repository using: > > > > > > mvn -Pquick -Dsurefire.useFile=false -DdisableXmlReport=true > > > -DuniqueVersion=false -ff -Dassemble -DskipTests -DfailIfNoTests=false > > > clean install > > > > > > Then on tomee-tck I execute: > > > ./runtests -Dhttps.protocols=TLSv1.1,TLSv1.2 --env -nc -c -d -w tomee > > > > > > com/sun/ts/tests/ejb30/lite/interceptor/singleton/lifecycle/annotated/Client#aroundConstructInterceptorTest_from_ejbembed > > > > > > But when I attach successfully the remote debugger in TomEE project, my > > > changes are not picked up when the tomee-tck is executing the code that > > > fails. > > > > > > If I rollback the tomee-tck to 8.0.0-M2 for both <openejb.version> > and > > > <tomee.version>, then the TomEE debugger doesn't ignore the tomee > classes > > > but if I add my changes then there are ignored since tomee-tck is using > > > tomee 8.0.0-M2. > > > > > > I also tried without success to use the -ol and --offline option > > indicated > > > in the ./runtest --help > > > > > > [1] https://github.com/apache/tomee-tck/blob/master/pom.xml#L41-L42 > > > > > > El mié., 6 feb. 2019 a las 18:10, César Hernández Mendoza (< > > > cesargu...@gmail.com>) escribió: > > > > > >> Hi, > > >> I want to share how I'm now chasing for failing tests for the TomEE > TCK > > >> execution. > > >> This has been a learning jorney from the three proyects: TomEE, > > tomee-tck > > >> and jakartaee-tck. > > >> > > >> > > >> First, a quick question for the list: > > >> Can someone from the list can double check if this test also fails on > > >> your side and share your tomee-tck/target/logs/javatest.log file? > > >> ./runtests -Dhttps.protocols=TLSv1.1,TLSv1.2 --env -nc -c -U -w tomee > > >> > > > com/sun/ts/tests/ejb30/lite/interceptor/singleton/lifecycle/annotated/Client#aroundConstructInterceptorTest_from_ejbembed > > >> > > >> > > >> > > >> Now proceeding with the details of how I ended up there: > > >> > > >> The first problem I overcome in the past days is how to identify from > > >> the 47,219 tests the ones related with web profile. > > >> For this, I created last week a PR that summaries this information and > > >> also tomee-tck debug options [1] > > >> > > >> With the help of the custom filter from the JT Harness filter, I > > identify > > >> the first group of test containing related "javaee_web_profile" tests: > > >> [com.sun.ts.tests.ejb30.lite] > > >> > > >> I proceed to run locally the following command: > > >> ./runtests -Dhttps.protocols=TLSv1.1,TLSv1.2 --env -nc -c -U -w tomee > > >> com.sun.ts.tests.ejb30.lite > > >> > > >> But it took on my laptop about 16 hours oO. > > >> I pasted the result on my ejb30/lite sheet [1], there is a filter > called > > >> "Show Failed" that you can use to filter the results. > > >> > > >> As you can see from 2222 test 2027 passed and 195 failed. This was > > >> interesting because my filter applied on JT harness UI was > > >> "javaee_web_profile" over the test packages but because each package > can > > >> have sub packages, I found that some of the failing tests like: > > autoCloseTest_from_ejbembed > > >> [3] are not javaee_web_profile tests so you need to be double checking > > with > > >> JT Harnes UI if the failing test is actually web_profile reateld. > > >> > > >> > > >> [1] > > >> > > > https://github.com/apache/tomee-tck/pull/8/files#diff-ba2698ef203cf2653a73e80874eefa3dR13 > > >> [2] > > >> > > > https://docs.google.com/spreadsheets/d/1oYO0RN-rg4Z7TgSLJ2u4iK4hOFHOXA49ech2y0N3kVw/edit?usp=sharing > > >> [3] > > >> > > > com/sun/ts/tests/ejb30/lite/packaging/embed/classloader/annotated/Client#java#autoCloseTest_from_ejbembed > > >> -- > > >> Atentamente: > > >> César Hernández Mendoza. > > >> > > > > > > > > > -- > > > Atentamente: > > > César Hernández Mendoza. > > > > > > > > > -- > > Atentamente: > > César Hernández Mendoza. > > > > > -- > Daniel "soro" Cunha > https://twitter.com/dvlc_ >
