> On Jun 9, 2020, at 2:45 PM, David Blevins <[email protected]> wrote: > >> On Jun 6, 2020, at 3:26 PM, David Blevins <[email protected]> wrote: >> >> All total about 2508 hits. >> > > With latest changes we're down to about 672 hits. > > - > https://github.com/dblevins/tomee-analysis/blob/6ee78178aa5dd55447943fd25cd5821f6159fc9e/README.adoc >
Ok, I expanded the search for potentially missed "javax" references to now also search non class files. This gives us a few thousand more hits (6053 total). Of them, 4980 are for javax.faces most across .tld, .js and .xsd files. At this point, it's a little unclear how to proceed. There are actually two problems: - Simple find/replace on all non-class files in a jar - Doing it elegantly not offending the design of the Eclipse Transformer The trick I'm having is I personally have a tendency to code like this: Phase 1: code till the problem is completely solved including each and every edge case. Avoid as much design overhead as possible, at this point they're just handcuffs. Phase 2: once phase 1 is fully complete, take stock of the code and redesign it with the whole picture in mind. I feel like where we are at with the Eclipse Transformer is it's already firming up the design and we're not out of phase 1 yet. I could be wrong on that. My fear is that we spend the next few weeks feeding edge-cases in one at a time, each time treating the design as perfect trying to make as few design changes as possible, sometimes going a little out of our way to make that happen and this drags on. Alternatively, we could just get to the end of this in a hacked fashion, get the server to boot and completely run, and *then* see what changes we'd need to make to the Eclipse Transformer design to get it to do what we need. Jon, you're the only one with experience with the Eclipse Transformer, I'm very curious what you think. -David
smime.p7s
Description: S/MIME cryptographic signature
