I like it - I've managed to follow what it's doing, and I imagine I could add further patches to it if needed :). Thank you for adding that. Much more scalable than my shading approach.
Apologies for the poms in my working copy I forgot to revert before committing everything. Thanks for fixing it. Jon On Mon, Jun 15, 2020 at 11:10 PM David Blevins <[email protected]> wrote: > > On Jun 15, 2020, at 9:23 AM, Jonathan Gallimore < > [email protected]> wrote: > > > > Thanks for this update. I've rebased the latest Eclipse Transformer code > > from upstream and will push that, and try a build with your PR. > > Thanks for the merge on PR 662, what did you think of the `src/patch/java` > concept and tomee-patch-plugin? Good, bad, ok-ish? > > > -David > > > > > > Jon > > > > On Mon, Jun 15, 2020 at 12:15 AM David Blevins <[email protected]> > > wrote: > > > >> Ok, here's a quick status as to where I got. > >> > >> - Picked through our remaining ambiguous "javax" string references and > >> fixed them by checking in the affected file at the library version we're > >> using, then took a look at their master branch to see how they've > adapter > >> for the "jakarta" namespace and applied that fix to our copy. > >> > >> - Updated the tomee-patch-plugin to update strings in files and in the > >> case of JSF update the path of the file; there are some > >> '*-resources/javax.faces/" files. Those were all renamed. > >> > >> - Applied any bytecode transformations that the Eclipse Transformer > >> missed. Strings in annotation values were not being updated, nor were > any > >> module-info classes. After that there were a few small string tweaks it > >> probably could handle with the right configuration, but I just wanted to > >> get this over with so I put them in the tomee-patch-plugin for now. > >> > >> - Updated the tomee-patch-plugin to remove any signatures that are on > any > >> jars. > >> > >> The server boots and looks pretty good at least from a cursory > >> perspective. We need to do some more testing. > >> > >> Here's the PR which I think is ready to be merged so others can continue > >> down this path. > >> > >> - https://github.com/apache/tomee/pull/662 > >> > >> > >> -David > >> > >> > >
