> On Jun 11, 2020, at 9:12 PM, David Blevins <[email protected]> wrote: > > Still some tweaks to do on getting the replacement into the jar, but so far > is looking really promising. > > The main goal was that any modifications we make to java files could be > tracked in the same TomEE branch that needs them.
Ok, it's working now. Let's say we have the following in our module: - src/patch/java/org/apache/cxf/jaxb/JAXBContextInitializer.java We would see happy output like this: [INFO] --- tomee-patch-plugin:0.1-SNAPSHOT:run (default) @ apache-tomee --- [INFO] Compiling 1 source file to /Users/dblevins/work/apache/tomee/tomee/apache-tomee/target/patch-classes [INFO] Patching apache-tomee-plus-8.0.3-SNAPSHOT/lib/cxf-rt-databinding-jaxb-3.3.6.jar [INFO] Patching apache-tomee-plume-8.0.3-SNAPSHOT/lib/cxf-rt-databinding-jaxb-3.3.6.jar [INFO] Patching apache-tomee-microprofile-8.0.3-SNAPSHOT/lib/cxf-rt-databinding-jaxb-3.3.6.jar [INFO] Applied 1 patches to 3 locations [INFO] Now let's say we have these files and `Anvil` doesn't match anything in any of our jars: - src/patch/java/org/acme/Anvil.java - src/patch/java/org/apache/cxf/jaxb/JAXBContextInitializer.java We would see a failed build with output like this: [INFO] --- tomee-patch-plugin:0.1-SNAPSHOT:run (default) @ apache-tomee --- [INFO] Compiling 2 source files to /Users/dblevins/work/apache/tomee/tomee/apache-tomee/target/patch-classes [INFO] Patching apache-tomee-plus-8.0.3-SNAPSHOT/lib/cxf-rt-databinding-jaxb-3.3.6.jar [INFO] Patching apache-tomee-plume-8.0.3-SNAPSHOT/lib/cxf-rt-databinding-jaxb-3.3.6.jar [INFO] Patching apache-tomee-microprofile-8.0.3-SNAPSHOT/lib/cxf-rt-databinding-jaxb-3.3.6.jar [INFO] Applied 1 patches to 3 locations [ERROR] Failed to apply 1 patches [ERROR] org/acme/Anvil.class [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 01:17 min [INFO] Finished at: 2020-06-12T11:18:20-07:00 [INFO] ------------------------------------------------------------------------ [ERROR] Failed to execute goal org.apache.tomee.patch:tomee-patch-plugin:0.1-SNAPSHOT:run (default) on project apache-tomee: Execution default of goal org.apache.tomee.patch:tomee-patch-plugin:0.1-SNAPSHOT:run failed: Failed to apply 1 patches -> [Help 1]
smime.p7s
Description: S/MIME cryptographic signature
