Hi, Sorry for the late post, been out of town the last few days. Today I've committed some changes to the binding and the sample consisting in formatting the code with the Tuscany Eclipse formatter, using the Tuscany code template and doing a little bit of refactoring where needed. This being done, we're good to go from my side to get the modules (binding-comet and binding-comet-runtime) and the sample (comet-webapp) into trunk. If somebody is willing to check them out and make some code review, that would be even better.
A few observations regarding the module would be the following: - The unit test from binding-comet-runtime consists in starting a node which defines a contribution with a comet service. This will fail if the machine on which this is executed has already taken the 8080 port. Is this feasible? I don't know how the Hudson environment will behave in such a situation. If problems occur we could simply rename CometTestCase to CometTest and leave the unit test to be run manually when needed. - I've also commited a copy of trunk/pom.xml and trunk/modules/pom.xml in the contrib and contrib/modules folders as a temporary solution as modules in the contrib folder define a parent pom with relative path "../pom.xml" which will lead to missing parent pom errors when no prior Tuscany trunk module builds are performed. This affected pretty much all the modules in contrib from what I've seen. Performed a build in a clean environment and didn't get any parent pom errors anymore. - It is possible that some changes will be needed in pom.xml when moving to trunk but I'm not that sure. Most probably, the only updates that will need to be done are located in parent poms. Feel free to give feedback regarding this new binding. Thanks, Florian On Fri, Aug 20, 2010 at 10:05 AM, Luciano Resende <luckbr1...@gmail.com>wrote: > Should we move the binding-comet-* from [1] to [2], this makes it > easier to others to load and give feedback to the new code. Or even > better, are we ready to move it to trunk ? > > [1] https://svn.apache.org/repos/asf/tuscany/sca-java-2.x/contrib/modules/ > [2] > https://svn.apache.org/repos/asf/tuscany/sca-java-2.x/trunk/contrib/modules/ > > -- > Luciano Resende > http://people.apache.org/~lresende > http://twitter.com/lresende1975 > http://lresende.blogspot.com/ >
