Github user chtyim commented on a diff in the pull request:

    https://github.com/apache/twill/pull/6#discussion_r76372010
  
    --- Diff: 
twill-yarn/src/main/hadoop21/org/apache/twill/internal/yarn/Hadoop21YarnAppClient.java
 ---
    @@ -127,6 +135,7 @@ private void addRMToken(ContainerLaunchContext context) 
{
           return;
         }
     
    +    YarnClient yarnClient = createYarnClient();
    --- End diff --
    
    This `addRMToken` method only gets called from the 
`ApplicationSubmitter.submit()` method, which only get triggered form the 
`createLauncher` method. Since there is already a new `YarnClient` created 
inside the `createLauncher` method, you can just have that one passed to this 
`addRMToken` method and use it instead of creating another one here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to