Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/6#discussion_r76372986
--- Diff:
twill-yarn/src/main/hadoop21/org/apache/twill/internal/yarn/Hadoop21YarnAppClient.java
---
@@ -197,6 +213,7 @@ public YarnApplicationReport getReport() {
public void cancel() {
try {
yarnClient.killApplication(appId);
+ yarnClient.stop();
--- End diff --
You have to keep this `yarnClient` for killing though since it is binding
to the user who launched the app.
You probably have to make `ProcessController` `AutoCloseable` so that on
application completion, you can close it from the `YarnTwillController`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
