Github user anwar6953 commented on a diff in the pull request:
https://github.com/apache/twill/pull/6#discussion_r76378540
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/RunnableProcessLauncher.java
---
@@ -76,6 +76,11 @@ public String toString() {
return new ProcessController<R>() {
@Override
+ public void close() throws Exception {
+ // no-op
--- End diff --
I just meant, now both close and cancel will kill the runnable?
On Aug 26, 2016 12:55 AM, "Terence Yim" <notificati...@github.com> wrote:
> In twill-yarn/src/main/java/org/apache/twill/internal/appmaster/
> RunnableProcessLauncher.java
> <https://github.com/apache/twill/pull/6#discussion_r76378304>:
>
> > @@ -76,6 +76,11 @@ public String toString() {
> >
> > return new ProcessController<R>() {
> > @Override
> > + public void close() throws Exception {
> > + // no-op
>
> Controller ties to the lifecycle of the stuff that it is controlling. What
> do mean by leave the runnable process running when closing the controller?
> Is it related to #4 <https://github.com/apache/twill/pull/4> ?
>
> â
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
>
<https://github.com/apache/twill/pull/6/files/7b7f472f52e17d5742c88f6818ba4150a05003b5..f5716b0e5765604427225b1716d75ea590c7aaee#r76378304>,
> or mute the thread
>
<https://github.com/notifications/unsubscribe-auth/ACU_EUN0tSXqJYX-qeGQOWRmzPOpQXYCks5qjpv6gaJpZM4JtyZN>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
