[
https://issues.apache.org/jira/browse/TWILL-185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15439419#comment-15439419
]
ASF GitHub Bot commented on TWILL-185:
--------------------------------------
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/7#discussion_r76454783
--- Diff:
twill-yarn/src/main/java/org/apache/twill/yarn/YarnTwillRunnerService.java ---
@@ -211,7 +226,7 @@ public String getJVMOptions() {
@Override
public Cancellable scheduleSecureStoreUpdate(final SecureStoreUpdater
updater,
long initialDelay, long
delay, TimeUnit unit) {
- if (!UserGroupInformation.isSecurityEnabled()) {
+ if (!UserGroupInformation.isSecurityEnabled() ||
!enableSecureStoreUpdate) {
--- End diff --
You shouldn't disable this one. Otherwise user won't be able to schedule
his own update. We should only disable the default one by Twill (the one that
update HDFS delegation tokens in `startUp`).
> Allow user to disable the SecureStoreUpdater in Twill
> -----------------------------------------------------
>
> Key: TWILL-185
> URL: https://issues.apache.org/jira/browse/TWILL-185
> Project: Apache Twill
> Issue Type: Improvement
> Components: api
> Affects Versions: 0.7.0-incubating
> Reporter: Ali Anwar
> Assignee: Ali Anwar
> Fix For: 0.8.0
>
>
> User can have their own SecureStoreUpdater scheduled.
> Having two of these schedules can cause issues (see TWILL-109).
> It also can cause conflicts with the updating done by the user's
> SecureStoreUpdater.
> Allowing the user to disable the SecureStoreUpdater in Twill is a simple way
> to resolve both of these issues.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
