[
https://issues.apache.org/jira/browse/TWILL-185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15447485#comment-15447485
]
ASF GitHub Bot commented on TWILL-185:
--------------------------------------
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/7#discussion_r76710103
--- Diff: twill-core/src/main/java/org/apache/twill/internal/Configs.java
---
@@ -31,6 +31,11 @@
*/
public static final String JAVA_RESERVED_MEMORY_MB =
"twill.java.reserved.memory.mb";
+ /**
+ * Set this to false to disable the secure store updates done by
default.
+ */
+ public static final String ENABLE_DEFAULT_SECURE_STORE_UPDATE =
"twill.secure.store.update.location.enabled";
--- End diff --
It's better to have the constant name matches with the value. E.g.
`SECURE_STORE_UPDATE_LOCATION_ENABLED`
> Allow user to disable the SecureStoreUpdater in Twill
> -----------------------------------------------------
>
> Key: TWILL-185
> URL: https://issues.apache.org/jira/browse/TWILL-185
> Project: Apache Twill
> Issue Type: Improvement
> Components: api
> Affects Versions: 0.7.0-incubating
> Reporter: Ali Anwar
> Assignee: Ali Anwar
> Fix For: 0.8.0
>
>
> User can have their own SecureStoreUpdater scheduled.
> Having two of these schedules can cause issues (see TWILL-109).
> It also can cause conflicts with the updating done by the user's
> SecureStoreUpdater.
> Allowing the user to disable the SecureStoreUpdater in Twill is a simple way
> to resolve both of these issues.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
