[
https://issues.apache.org/jira/browse/TWILL-185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15439423#comment-15439423
]
ASF GitHub Bot commented on TWILL-185:
--------------------------------------
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/7#discussion_r76454915
--- Diff:
twill-yarn/src/main/java/org/apache/twill/yarn/YarnTwillRunnerService.java ---
@@ -157,11 +158,25 @@ public YarnTwillRunnerService(YarnConfiguration
config, String zkConnect) {
* @param locationFactory Factory to create {@link Location} instances
that are readable and writable by this service
*/
public YarnTwillRunnerService(YarnConfiguration config, String
zkConnect, LocationFactory locationFactory) {
+ this(config, zkConnect, locationFactory, true);
+ }
+
+ /**
+ * Creates an instance.
+ *
+ * @param config Configuration of the yarn cluster
+ * @param zkConnect ZooKeeper connection string
+ * @param locationFactory Factory to create {@link Location} instances
that are readable and writable by this service
+ * @param enableSecureStoreUpdate Whether to update SecureStore
periodically
+ */
+ public YarnTwillRunnerService(YarnConfiguration config, String
zkConnect, LocationFactory locationFactory,
+ boolean enableSecureStoreUpdate) {
this.yarnConfig = config;
this.yarnAppClient = new
VersionDetectYarnAppClientFactory().create(config);
this.locationFactory = locationFactory;
this.zkClientService = getZKClientService(zkConnect);
this.controllers = HashBasedTable.create();
+ this.enableSecureStoreUpdate = enableSecureStoreUpdate;
--- End diff --
Better use a configuration passed in from the `YarnConfiguration`. The keys
should be defined in `Configs.Keys` class.
> Allow user to disable the SecureStoreUpdater in Twill
> -----------------------------------------------------
>
> Key: TWILL-185
> URL: https://issues.apache.org/jira/browse/TWILL-185
> Project: Apache Twill
> Issue Type: Improvement
> Components: api
> Affects Versions: 0.7.0-incubating
> Reporter: Ali Anwar
> Assignee: Ali Anwar
> Fix For: 0.8.0
>
>
> User can have their own SecureStoreUpdater scheduled.
> Having two of these schedules can cause issues (see TWILL-109).
> It also can cause conflicts with the updating done by the user's
> SecureStoreUpdater.
> Allowing the user to disable the SecureStoreUpdater in Twill is a simple way
> to resolve both of these issues.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
