Github user chtyim commented on a diff in the pull request:

    https://github.com/apache/twill/pull/6#discussion_r76685638
  
    --- Diff: 
twill-yarn/src/main/hadoop20/org/apache/twill/internal/yarn/Hadoop20YarnAppClient.java
 ---
    @@ -62,18 +62,26 @@
     public final class Hadoop20YarnAppClient extends AbstractIdleService 
implements YarnAppClient {
     
       private static final Logger LOG = 
LoggerFactory.getLogger(Hadoop20YarnAppClient.class);
    -  private final YarnClient yarnClient;
    +  private final Configuration configuration;
       private String user;
     
       public Hadoop20YarnAppClient(Configuration configuration) {
    -    this.yarnClient = new YarnClientImpl();
    -    yarnClient.init(configuration);
    +    this.configuration = configuration;
         this.user = System.getProperty("user.name");
       }
     
    +  // Creates and starts a yarn client
    +  private YarnClient createYarnClient() {
    +    YarnClient yarnClient = new YarnClientImpl();
    +    yarnClient.init(configuration);
    +    yarnClient.start();
    +    return yarnClient;
    +  }
    +
       @Override
       public ProcessLauncher<ApplicationMasterInfo> 
createLauncher(TwillSpecification twillSpec,
                                                                    @Nullable 
String schedulerQueue) throws Exception {
    +    final YarnClient yarnClient = createYarnClient();
    --- End diff --
    
    Nevermind, I found it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to