[
https://issues.apache.org/jira/browse/TWILL-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15570002#comment-15570002
]
ASF GitHub Bot commented on TWILL-138:
--------------------------------------
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r83108468
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/TwillContainerLauncher.java
---
@@ -84,22 +84,29 @@ public TwillContainerLauncher(RuntimeSpecification
runtimeSpec, ContainerInfo co
* @param classPath The class path to load classes for the container.
* @return instance of {@link TwillContainerController} to control the
container run.
*/
- public TwillContainerController start(RunId runId, int instanceId,
Class<?> mainClass, String classPath) {
+ public TwillContainerController start(RunId runId, int instanceId,
Class<?> mainClass, String classPath,
+ Location logLevelLocation) {
--- End diff --
Is `logLevelLocation` nullable? I see you check that in line 104. If that's
the case, annotate this parameter with `@Nullable`. Also, please update the
javadoc accordingly.
> Runtime change of Application runnable log level
> ------------------------------------------------
>
> Key: TWILL-138
> URL: https://issues.apache.org/jira/browse/TWILL-138
> Project: Apache Twill
> Issue Type: New Feature
> Components: core
> Reporter: Henry Saputra
>
> With TWILL-24 is supported for setting log level when starting the Twill
> application, next enhancement is to able to send command to update the
> aggregate log level for a particular runnable in a Twill application.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
