[
https://issues.apache.org/jira/browse/TWILL-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15570009#comment-15570009
]
ASF GitHub Bot commented on TWILL-138:
--------------------------------------
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r83108634
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/TwillRuntimeSpecification.java
---
@@ -40,11 +41,13 @@
private final int reservedMemory;
private final String rmSchedulerAddr;
private final LogEntry.Level logLevel;
+ private final Map<String, Map<String, LogEntry.Level>> logLevels;
public TwillRuntimeSpecification(TwillSpecification twillSpecification,
String fsUser, URI twillAppDir,
String zkConnectStr, RunId twillRunId,
String twillAppName,
int reservedMemory, @Nullable String
rmSchedulerAddr,
- @Nullable LogEntry.Level logLevel) {
+ @Nullable LogEntry.Level logLevel,
--- End diff --
better rename this as `rootLogLevel`, just like in other classes. Also
rename the getter.
> Runtime change of Application runnable log level
> ------------------------------------------------
>
> Key: TWILL-138
> URL: https://issues.apache.org/jira/browse/TWILL-138
> Project: Apache Twill
> Issue Type: New Feature
> Components: core
> Reporter: Henry Saputra
>
> With TWILL-24 is supported for setting log level when starting the Twill
> application, next enhancement is to able to send command to update the
> aggregate log level for a particular runnable in a Twill application.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
