[
https://issues.apache.org/jira/browse/TWILL-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15566793#comment-15566793
]
ASF GitHub Bot commented on TWILL-138:
--------------------------------------
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r82901178
--- Diff:
twill-yarn/src/main/java/org/apache/twill/yarn/YarnTwillPreparer.java ---
@@ -298,6 +299,29 @@ public TwillPreparer addSecureStore(SecureStore
secureStore) {
public TwillPreparer setLogLevel(LogEntry.Level logLevel) {
Preconditions.checkNotNull(logLevel);
this.logLevel = logLevel;
+ Map<String, LogEntry.Level> logLevels = new HashMap<>();
+ logLevels.put(Logger.ROOT_LOGGER_NAME, logLevel);
+ saveLogLevels(Constants.SystemMessages.LOG_ALL_RUNNABLES, logLevels);
--- End diff --
Why use the `LOG_ALL_RUNNABLES` as a runnable name? We have the `twillSpec`
in this class, so it's easy to just expand the log level settings for each
runnable.
> Runtime change of Application runnable log level
> ------------------------------------------------
>
> Key: TWILL-138
> URL: https://issues.apache.org/jira/browse/TWILL-138
> Project: Apache Twill
> Issue Type: New Feature
> Components: core
> Reporter: Henry Saputra
>
> With TWILL-24 is supported for setting log level when starting the Twill
> application, next enhancement is to able to send command to update the
> aggregate log level for a particular runnable in a Twill application.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
