[
https://issues.apache.org/jira/browse/TWILL-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15570253#comment-15570253
]
ASF GitHub Bot commented on TWILL-138:
--------------------------------------
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r83109907
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/state/SystemMessages.java ---
@@ -68,6 +73,31 @@ public static Message updateRunnablesInstances(Command
updateCommand) {
return new SimpleMessage(Message.Type.SYSTEM, Message.Scope.RUNNABLES,
null, updateCommand);
}
+ /**
+ * Helper method to get System {@link Message} for changing the log
levels for all runnables.
+ *
+ * @param logLevels The log levels to be changed.
+ * @return An instance of System {@link Message} to change the log
levels.
+ */
+ public static Message setLogLevels(Map<String, LogEntry.Level>
logLevels) {
+ return setLogLevels(null, logLevels);
+ }
+
+ /**
+ * Helper method to get System {@link Message} for changing the log
levels for one or all runnables.
+ *
+ * @param runnableName The name of the runnable to set the log level,
ALL if apply to all runnables.
+ * @param logLevels The log levels to be changed.
+ * @return An instance of System {@link Message} to change the log
levels.
+ */
+ public static Message setLogLevels(String runnableName, Map<String,
LogEntry.Level> logLevels) {
--- End diff --
Seems like `runnableName` is nullable. Please add the `@Nullable`
annotation.
> Runtime change of Application runnable log level
> ------------------------------------------------
>
> Key: TWILL-138
> URL: https://issues.apache.org/jira/browse/TWILL-138
> Project: Apache Twill
> Issue Type: New Feature
> Components: core
> Reporter: Henry Saputra
>
> With TWILL-24 is supported for setting log level when starting the Twill
> application, next enhancement is to able to send command to update the
> aggregate log level for a particular runnable in a Twill application.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
