[
https://issues.apache.org/jira/browse/TWILL-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15570262#comment-15570262
]
ASF GitHub Bot commented on TWILL-138:
--------------------------------------
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r83117619
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/RunningContainers.java
---
@@ -98,17 +109,23 @@ public Integer apply(BitSet input) {
private final Condition containerChange;
private final ZKClient zkClient;
private final Multimap<String, ContainerInfo> containerStats;
+ private final Location applicationLocation;
+ private final List<String> allRunnableNames;
- RunningContainers(String appId, TwillRunResources appMasterResources,
ZKClient zookeeperClient) {
+ RunningContainers(String appId, TwillRunResources appMasterResources,
ZKClient zookeeperClient,
+ Map<String, Map<String, LogEntry.Level>> logLevels,
Location appLocation,
+ List<String> allRunnables) {
containers = HashBasedTable.create();
runnableInstances = Maps.newHashMap();
completedContainerCount = Maps.newHashMap();
startSequence = Lists.newLinkedList();
containerLock = new ReentrantLock();
containerChange = containerLock.newCondition();
- resourceReport = new DefaultResourceReport(appId, appMasterResources);
+ resourceReport = new DefaultResourceReport(appId, appMasterResources,
logLevels);
zkClient = zookeeperClient;
containerStats = HashMultimap.create();
+ applicationLocation = appLocation;
+ allRunnableNames = allRunnables;
--- End diff --
Better have the argument and the field named the same for clarity.
> Runtime change of Application runnable log level
> ------------------------------------------------
>
> Key: TWILL-138
> URL: https://issues.apache.org/jira/browse/TWILL-138
> Project: Apache Twill
> Issue Type: New Feature
> Components: core
> Reporter: Henry Saputra
>
> With TWILL-24 is supported for setting log level when starting the Twill
> application, next enhancement is to able to send command to update the
> aggregate log level for a particular runnable in a Twill application.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
