Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r87239353
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/AbstractTwillController.java
---
@@ -170,6 +171,37 @@ public String apply(Set<String> input) {
});
}
+ @Override
+ public Future<LogEntry.Level> setRootLogLevel(LogEntry.Level logLevel) {
+ return
sendMessage(SystemMessages.setLogLevels(ImmutableMap.of(Logger.ROOT_LOGGER_NAME,
logLevel)), logLevel);
+ }
+
+ @Override
+ public Future<LogEntry.Level> setRootLogLevel(String runnableName,
LogEntry.Level logLevel) {
+ return sendMessage(SystemMessages.setLogLevels(runnableName,
ImmutableMap.of(Logger.ROOT_LOGGER_NAME, logLevel)),
+ logLevel);
+ }
+
+ @Override
+ public Future<Map<String, LogEntry.Level>> setLogLevels(Map<String,
LogEntry.Level> logLevels) {
+ return sendMessage(SystemMessages.setLogLevels(logLevels), logLevels);
+ }
+
+ @Override
+ public Future<Map<String, LogEntry.Level>> setLogLevels(String
runnableName,
+ Map<String,
LogEntry.Level> runnableLogLevels) {
+ return sendMessage(SystemMessages.setLogLevels(runnableName,
runnableLogLevels), runnableLogLevels);
+ }
+
+ @Override
+ public Future<String> resetLogLevelsToDefault() {
+ return sendMessage(SystemMessages.resetLogLevels(null), "all");
--- End diff --
This is inconsistent with the `setLogLevels` method, which doesn't require
explicitly passing in `null` for all runnables case.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
