Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r87242433
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/ContainerLiveNodeData.java
---
@@ -43,4 +51,15 @@ public String getHost() {
public String getDebugPort() {
return debugPort;
}
+
+ public Map<String, LogEntry.Level> getLogLevels() {
+ return logLevels;
+ }
+
+ public void updateLogLevels(Map<String, LogEntry.Level> logLevels,
boolean isReset) {
+ if (isReset) {
--- End diff --
This is not a good way overloading the responsibility of this method.
Better have a separate method for resetting (and that mirrors the actual
functionality being exposed through the public API).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
