Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/14#discussion_r87237480
--- Diff: twill-api/src/main/java/org/apache/twill/api/TwillPreparer.java
---
@@ -227,15 +227,52 @@
TwillPreparer addSecureStore(SecureStore secureStore);
/**
- * Set the log level for Twill applications running in a container.
+ * Set the root log level for Twill applications in all containers.
*
* @param logLevel the {@link LogEntry.Level} that should be set.
* The level match the {@code Logback} levels.
* @return This {@link TwillPreparer}.
+ * @deprecated Use {@link #setRootLogLevel(LogEntry.Level)} instead.
*/
+ @Deprecated
TwillPreparer setLogLevel(LogEntry.Level logLevel);
/**
+ * Set the root log level for Twill applications in all containers.
+ *
+ * @param logLevel the {@link LogEntry.Level} that should be set.
+ * The level match the {@code Logback} levels.
+ * @return This {@link TwillPreparer}.
+ */
+ TwillPreparer setRootLogLevel(LogEntry.Level logLevel);
+
+ /**
+ * Set the root log level for a particular runnable
+ *
+ * @param runnableName The name of the runnable to set the log level.
+ * @param logLevel the {@link LogEntry.Level} that should be set.
+ * @return This {@link TwillPreparer}.
+ */
+ TwillPreparer setRootLogLevel(String runnableName, LogEntry.Level
logLevel);
--- End diff --
I prefer not to introduce the `setRootLogLevel` and the deprecated
`setLogLevel` replaced with call to `setLogLevel(Map)` with logger name
`Logger.ROOT_LOGGER_NAME` to set root logger log level.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
