Github user maochf commented on a diff in the pull request:

    https://github.com/apache/twill/pull/16#discussion_r94555234
  
    --- Diff: 
twill-core/src/main/java/org/apache/twill/internal/kafka/client/SimpleKafkaConsumer.java
 ---
    @@ -68,7 +69,7 @@
     /**
      * A {@link KafkaConsumer} implementation using the scala kafka api.
      */
    -final class SimpleKafkaConsumer implements KafkaConsumer {
    +public final class SimpleKafkaConsumer implements KafkaConsumer {
    --- End diff --
    
    Right, this can be done in the unit test. To phrase my question better, 
what can be a better way to perform the same logic as `getLastOffset` outside 
of `SimpleKafkaConsumer`? Maybe expose the parameter passed to 
`SimpleKafkaConsumer` constructor in `ZKKafkaClientService`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to