Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/16#discussion_r94687750
--- Diff:
twill-core/src/main/java/org/apache/twill/kafka/client/KafkaConsumer.java ---
@@ -35,12 +35,14 @@
* Invoked when new messages is available.
* @param messages Iterator of new messages. The {@link
FetchedMessage} instance maybe reused in the Iterator
* and across different invocation.
+ * @param startOffset Offset of the current message to be consumed.
+ * @return The offset of the message to be fetched next.
*/
- void onReceived(Iterator<FetchedMessage> messages);
+ long onReceived(Iterator<FetchedMessage> messages, long startOffset);
--- End diff --
Can you revert the ordering of the parameters? Logically it fetches from
the `startOffset` to produce the `Iterator`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
