Github user poornachandra commented on a diff in the pull request:
https://github.com/apache/twill/pull/23#discussion_r98075925
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/RunningContainers.java
---
@@ -113,9 +117,11 @@ public Integer apply(BitSet input) {
private final Location applicationLocation;
private final Set<String> runnableNames;
private final Map<String, Map<String, String>> logLevels;
+ private final Map<String, Integer> maxRetries;
--- End diff --
On further thought, I think if we track the restarts per instance id then
it would simplify the contract for max retries. This will be consistent with
what the javadoc says too -
```
Sets the maximum number of times (per instance) a runnable will be retried
if it exits without success. The default behavior is to retry indefinitely.
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
