Github user serranom commented on a diff in the pull request:
https://github.com/apache/twill/pull/23#discussion_r98334746
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/RunningContainers.java
---
@@ -113,9 +117,11 @@ public Integer apply(BitSet input) {
private final Location applicationLocation;
private final Set<String> runnableNames;
private final Map<String, Map<String, String>> logLevels;
+ private final Map<String, Integer> maxRetries;
--- End diff --
but on second thought, the additional complexity of tracking by instance id
would handle the following case better:
- initially start with `x` instances, all of which succeed.
- add 1 more instance, which fails
If tracking by instance id, the new instance will get maxRetries. Without
tracking by instance id, the new instance would get `maxRetries*(x+1)` retries.
So I will add the complexity of keeping track by id. It seems worth it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
