Github user serranom commented on a diff in the pull request:
https://github.com/apache/twill/pull/23#discussion_r98334088
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/RunningContainers.java
---
@@ -113,9 +117,11 @@ public Integer apply(BitSet input) {
private final Location applicationLocation;
private final Set<String> runnableNames;
private final Map<String, Map<String, String>> logLevels;
+ private final Map<String, Integer> maxRetries;
--- End diff --
@poornachandra, I don't see anything linking one instance request to a
retry of that failure. Failures get added to the multiset which then results
in a new request for that many instances. This means in the end, there is
nothing tying one attempt for a particular instanceId to the next one. So we
could keep track of retries by instanceId, but it would end up functionally
being the same as keeping track of retries for the entire Runnable. I think it
would just add more complexity for little benefit to track by instanceId.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
