[
https://issues.apache.org/jira/browse/TWILL-216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15871346#comment-15871346
]
ASF GitHub Bot commented on TWILL-216:
--------------------------------------
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/33#discussion_r101699432
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/TwillRuntimeSpecification.java
---
@@ -41,11 +41,23 @@
private final String rmSchedulerAddr;
private final Map<String, Map<String, String>> logLevels;
private final Map<String, Integer> maxRetries;
+ private Double heapToReserveRatio;
--- End diff --
Shouldn't allow null. This is an internal class, you can simply require the
caller to pass in valid value.
> Make ratio between total memory and on-heap memory configurable
> ---------------------------------------------------------------
>
> Key: TWILL-216
> URL: https://issues.apache.org/jira/browse/TWILL-216
> Project: Apache Twill
> Issue Type: Improvement
> Components: yarn
> Reporter: Yuliya Feldman
> Assignee: Yuliya Feldman
>
> As of now ratio between on-heap memory and total memory provided to yarn
> container is hardcoded to 0.7, so if app running in the container needs more
> reserved memory than on-heap it is not possible to achieve.
> Suggestion is to make it configurable as well as amount of reserved memory
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
