[
https://issues.apache.org/jira/browse/TWILL-216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15871347#comment-15871347
]
ASF GitHub Bot commented on TWILL-216:
--------------------------------------
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/33#discussion_r101699339
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/TwillContainerLauncher.java
---
@@ -59,19 +59,21 @@
private final int instanceCount;
private final JvmOptions jvmOpts;
private final int reservedMemory;
+ private final Double heapToReservedRatio;
private final Location secureStoreLocation;
public TwillContainerLauncher(RuntimeSpecification runtimeSpec,
ContainerInfo containerInfo,
ProcessLauncher.PrepareLaunchContext
launchContext,
ZKClient zkClient, int instanceCount,
JvmOptions jvmOpts, int reservedMemory,
- Location secureStoreLocation) {
+ Location secureStoreLocation, Double
heapToReservedRatio) {
--- End diff --
Better to have `minHeapRatio` a `double` and the caller need to make sure
it is not null.
> Make ratio between total memory and on-heap memory configurable
> ---------------------------------------------------------------
>
> Key: TWILL-216
> URL: https://issues.apache.org/jira/browse/TWILL-216
> Project: Apache Twill
> Issue Type: Improvement
> Components: yarn
> Reporter: Yuliya Feldman
> Assignee: Yuliya Feldman
>
> As of now ratio between on-heap memory and total memory provided to yarn
> container is hardcoded to 0.7, so if app running in the container needs more
> reserved memory than on-heap it is not possible to achieve.
> Suggestion is to make it configurable as well as amount of reserved memory
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
