[
https://issues.apache.org/jira/browse/TWILL-216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15871351#comment-15871351
]
ASF GitHub Bot commented on TWILL-216:
--------------------------------------
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/33#discussion_r101698978
--- Diff: twill-api/src/main/java/org/apache/twill/api/Configs.java ---
@@ -75,6 +82,7 @@ private Keys() {
*/
public static final int JAVA_RESERVED_MEMORY_MB = 200;
+ public static final double HEAP_RESERVED_MIN_RATIO_DEFAULT =
Constants.HEAP_MIN_RATIO;
--- End diff --
Inside the `Defaults` class, no need to repeat the variable with `DEFAULT`.
Just name it the same as the config key constant.
> Make ratio between total memory and on-heap memory configurable
> ---------------------------------------------------------------
>
> Key: TWILL-216
> URL: https://issues.apache.org/jira/browse/TWILL-216
> Project: Apache Twill
> Issue Type: Improvement
> Components: yarn
> Reporter: Yuliya Feldman
> Assignee: Yuliya Feldman
>
> As of now ratio between on-heap memory and total memory provided to yarn
> container is hardcoded to 0.7, so if app running in the container needs more
> reserved memory than on-heap it is not possible to achieve.
> Suggestion is to make it configurable as well as amount of reserved memory
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
