Github user sameetandpotatoes commented on a diff in the pull request:
https://github.com/apache/twill/pull/58#discussion_r129645453
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java
---
@@ -222,6 +226,7 @@ protected void doStart() throws Exception {
// initialize the event handler, if it fails, it will fail the
application.
if (eventHandler != null) {
eventHandler.initialize(new
BasicEventHandlerContext(twillSpec.getEventHandler()));
+ eventHandler.started(twillRuntimeSpec.getTwillAppName(),
twillRuntimeSpec.getTwillAppRunId());
--- End diff --
According to the comment above this `if` statement, if the event handler
fails to initialize, will any twill application state be recorded?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
