Github user maochf commented on a diff in the pull request:

    https://github.com/apache/twill/pull/58#discussion_r130491020
  
    --- Diff: twill-api/src/main/java/org/apache/twill/api/EventHandler.java ---
    @@ -124,6 +124,74 @@ public void initialize(EventHandlerContext context) {
       }
     
       /**
    +   * Invoked by the application when it starts.
    +   *
    +   * @param twillAppName name of the current application
    +   * @param runId run ID of current application run
    +   */
    +  public void started(String twillAppName, RunId runId) {
    +    // No-op
    +  }
    +
    +  /**
    +   * Invoked by the application when new container is launched for {@link 
TwillRunnable}.
    +   *
    +   * @param twillAppName name of the current application
    +   * @param runId run ID of current application run
    +   * @param runnableName name of the runnable to be run in the new 
container
    +   * @param instanceId the instance ID of the runnable instance to be run 
in the new container
    +   * @param containerId the ID of the newly launched container
    +   */
    +  public void containerLaunched(String twillAppName, RunId runId, String 
runnableName,
    +                                int instanceId, String containerId) {
    +    // No-op
    +  }
    +
    +  /**
    +   * Invoked by the application when a container is stopped.
    +   *
    +   * @param twillAppName name of the current application
    +   * @param runId run ID of current application run
    +   * @param runnableName name of the runnable in the stopped container
    +   * @param instanceId the instance ID of the runnable instance run in the 
stopped container
    +   * @param containerId the ID of the stopped container
    +   */
    +  public void containerStopped(String twillAppName, RunId runId, String 
runnableName,
    +                               int instanceId, String containerId) {
    +    // No-op
    +  }
    +
    +  /**
    +   * Invoked by the application when all containers complete.
    +   *
    +   * @param twillAppName name of the current application
    +   * @param runId run ID of current application run
    +   */
    +  public void completed(String twillAppName, RunId runId) {
    +    // No-op
    +  }
    +
    +  /**
    +   * Invoked by the application when stop command is received to kill the 
current application.
    +   *
    +   * @param twillAppName name of the current application
    +   * @param runId run ID of current application run
    +   */
    +  public void killed(String twillAppName, RunId runId) {
    +    // No-op
    +  }
    +
    +  /**
    +   * Invoked by the application when the application is aborted because of 
timeout.
    +   *
    +   * @param twillAppName name of the current application
    +   * @param runId run ID of current application run
    +   */
    +  public void aborted(String twillAppName, RunId runId) {
    +    // No-op
    +  }
    +
    +  /**
        * Invoked by the application when shutting down.
        */
       public void destroy() {
    --- End diff --
    
    what should be the default action of `launchTimeout`? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to