Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/58#discussion_r131210382
--- Diff:
twill-yarn/src/main/java/org/apache/twill/internal/appmaster/ApplicationMasterService.java
---
@@ -291,6 +301,23 @@ public void run() {
// Since all the runnables are now stopped, it is okay to stop the
poller.
stopPoller.shutdownNow();
cleanupDir();
+ if (eventHandler != null) {
+ if (finalStatus == null) {
+ // if finalStatus is not set, the application must be stopped by a
SystemMessages#STOP_COMMAND
+ eventHandler.killed(twillRuntimeSpec.getTwillAppName(),
twillRuntimeSpec.getTwillAppRunId());
+ }
+ switch (finalStatus) {
--- End diff --
This may have NPE. Should have a `else`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
