Github user anew commented on a diff in the pull request:
https://github.com/apache/twill/pull/59#discussion_r131511104
--- Diff:
twill-yarn/src/test/java/org/apache/twill/yarn/ContainerSizeTestRun.java ---
@@ -67,20 +69,37 @@ public void testContainerSize() throws
InterruptedException, TimeoutException, E
@Test
public void testMaxHeapSize() throws InterruptedException,
TimeoutException, ExecutionException {
TwillRunner runner = getTwillRunner();
+ String runnableName = "sleep";
+
TwillController controller = runner.prepare(new MaxHeapApp())
- // Alter the AM container size
-
.withConfiguration(Collections.singletonMap(Configs.Keys.YARN_AM_MEMORY_MB,
"256"))
+ // Alter the AM container size and heap ratio
+ .withConfiguration(ImmutableMap.of(Configs.Keys.YARN_AM_MEMORY_MB,
"256",
+
Configs.Keys.HEAP_RESERVED_MIN_RATIO, "0.65"))
+ // Use a different heap ratio and reserved memory size for the
runnable
+ .withConfiguration(runnableName,
+
ImmutableMap.of(Configs.Keys.HEAP_RESERVED_MIN_RATIO, "0.8",
--- End diff --
can you add a test that, if this config for the runnable does not have
HEAP_RESERVED_MIN_RATIO, it defaults to the one above (0.65) and not the system
default.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
