Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/59#discussion_r131511349
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/TwillRuntimeSpecification.java
---
@@ -87,19 +86,46 @@ public String getTwillAppName() {
return twillAppName;
}
- public int getReservedMemory() {
- return reservedMemory;
+ /**
+ * Returns the minimum heap ratio for the application master.
+ */
+ public double getAMMinHeapRatio() {
+ return getMinHeapRatio(config);
+ }
+
+ /**
+ * Returns the minimum heap ratio for the given runnable.
+ */
+ public double getMinHeapRatio(String runnableName) {
+ return getMinHeapRatio(runnableConfigs.containsKey(runnableName) ?
runnableConfigs.get(runnableName) : config);
--- End diff --
Agree. Get it wrong after some refactoring
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
