Github user anew commented on a diff in the pull request:
https://github.com/apache/twill/pull/59#discussion_r131708495
--- Diff:
twill-core/src/main/java/org/apache/twill/internal/TwillRuntimeSpecification.java
---
@@ -171,9 +168,27 @@ public String getKafkaZKConnect() {
/**
* Returns the minimum heap ratio ({@link
Configs.Keys#HEAP_RESERVED_MIN_RATIO}) based on the given configuration.
*/
- private double getMinHeapRatio(Map<String, String> config) {
- return config.containsKey(Configs.Keys.HEAP_RESERVED_MIN_RATIO) ?
- Double.parseDouble(config.get(Configs.Keys.HEAP_RESERVED_MIN_RATIO))
:
- Configs.Defaults.HEAP_RESERVED_MIN_RATIO;
+ private double getMinHeapRatio(@Nullable Map<String, String> config,
double defaultValue) {
+ if (config == null) {
--- End diff --
I think this would be easier to read, and it would give better errors, as
follows:
```
if (config == null || !config.containsKey(...)) {
return defaultValue;
}
try {
double ratio = Double.parseDouble(config.get(...));
} catch (NumberFormatException) {
// either warn or throw a more informative exn (including runnable name
and the bad value)
}
if (ratio <= 0d) {
// either warn or throw a more informative exn (including runnable name
and the bad value)
}
return ratio;
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
