[
https://issues.apache.org/jira/browse/TWILL-241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16115184#comment-16115184
]
ASF GitHub Bot commented on TWILL-241:
--------------------------------------
Github user anew commented on a diff in the pull request:
https://github.com/apache/twill/pull/59#discussion_r131511104
--- Diff:
twill-yarn/src/test/java/org/apache/twill/yarn/ContainerSizeTestRun.java ---
@@ -67,20 +69,37 @@ public void testContainerSize() throws
InterruptedException, TimeoutException, E
@Test
public void testMaxHeapSize() throws InterruptedException,
TimeoutException, ExecutionException {
TwillRunner runner = getTwillRunner();
+ String runnableName = "sleep";
+
TwillController controller = runner.prepare(new MaxHeapApp())
- // Alter the AM container size
-
.withConfiguration(Collections.singletonMap(Configs.Keys.YARN_AM_MEMORY_MB,
"256"))
+ // Alter the AM container size and heap ratio
+ .withConfiguration(ImmutableMap.of(Configs.Keys.YARN_AM_MEMORY_MB,
"256",
+
Configs.Keys.HEAP_RESERVED_MIN_RATIO, "0.65"))
+ // Use a different heap ratio and reserved memory size for the
runnable
+ .withConfiguration(runnableName,
+
ImmutableMap.of(Configs.Keys.HEAP_RESERVED_MIN_RATIO, "0.8",
--- End diff --
can you add a test that, if this config for the runnable does not have
HEAP_RESERVED_MIN_RATIO, it defaults to the one above (0.65) and not the system
default.
> Allow specifying reserved off-heap memory and extra JVM options per runnable
> ----------------------------------------------------------------------------
>
> Key: TWILL-241
> URL: https://issues.apache.org/jira/browse/TWILL-241
> Project: Apache Twill
> Issue Type: Improvement
> Components: api, yarn
> Affects Versions: 0.11.0
> Reporter: Andreas Neumann
> Assignee: Terence Yim
> Fix For: 0.12.0
>
>
> Sometimes, a particular runnable needs a lot more off-heap memory than
> others. It would therefore be useful to specify the amount of reserved
> non-heap memory per runnable.
> Similarly, for example, for debugging purposes, it may be necessary to add a
> JVM option for one of the runnables without affecting the other runnables of
> the same application.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
