[
https://issues.apache.org/jira/browse/TWILL-241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16115192#comment-16115192
]
ASF GitHub Bot commented on TWILL-241:
--------------------------------------
Github user chtyim commented on a diff in the pull request:
https://github.com/apache/twill/pull/59#discussion_r131511384
--- Diff:
twill-yarn/src/main/java/org/apache/twill/yarn/YarnTwillPreparer.java ---
@@ -183,6 +184,13 @@ public TwillPreparer withConfiguration(Map<String,
String> config) {
}
@Override
+ public TwillPreparer withConfiguration(String runnableName, Map<String,
String> config) {
--- End diff --
Should default to the app setting first, then to the constants default
> Allow specifying reserved off-heap memory and extra JVM options per runnable
> ----------------------------------------------------------------------------
>
> Key: TWILL-241
> URL: https://issues.apache.org/jira/browse/TWILL-241
> Project: Apache Twill
> Issue Type: Improvement
> Components: api, yarn
> Affects Versions: 0.11.0
> Reporter: Andreas Neumann
> Assignee: Terence Yim
> Fix For: 0.12.0
>
>
> Sometimes, a particular runnable needs a lot more off-heap memory than
> others. It would therefore be useful to specify the amount of reserved
> non-heap memory per runnable.
> Similarly, for example, for debugging purposes, it may be necessary to add a
> JVM option for one of the runnables without affecting the other runnables of
> the same application.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
